From owner-cvs-all@FreeBSD.ORG  Mon Apr 30 14:48:08 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B89EC16A402;
	Mon, 30 Apr 2007 14:48:08 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69])
	by mx1.freebsd.org (Postfix) with ESMTP id 3998C13C457;
	Mon, 30 Apr 2007 14:48:07 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l3UEm2BG055748;
	Mon, 30 Apr 2007 18:48:02 +0400 (MSD)
	(envelope-from ache@nagual.pp.ru)
Received: (from ache@localhost)
	by nagual.pp.ru (8.14.1/8.14.1/Submit) id l3UEm2sY055747;
	Mon, 30 Apr 2007 18:48:02 +0400 (MSD) (envelope-from ache)
Date: Mon, 30 Apr 2007 18:48:02 +0400
From: Andrey Chernov <ache@FreeBSD.org>
To: "M. Warner Losh" <imp@bsdimp.com>
Message-ID: <20070430144802.GA55665@nagual.pp.ru>
Mail-Followup-To: Andrey Chernov <ache@freebsd.org>,
	"M. Warner Losh" <imp@bsdimp.com>, src-committers@FreeBSD.org,
	cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
References: <200704301144.l3UBig50070087@repoman.freebsd.org>
	<20070430.082645.270753761.imp@bsdimp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070430.082645.270753761.imp@bsdimp.com>
User-Agent: Mutt/1.5.15 (2007-04-06)
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/bin/sh var.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Apr 2007 14:48:08 -0000

On Mon, Apr 30, 2007 at 08:26:45AM -0600, M. Warner Losh wrote:
> Andrey,
> 
> Can you bump the __FreeBSD_version in sys/param.h for these changes
> and document it in the FreeBSD committer's handbook?

Yes, of course, but a bit later. Currently changes are in progress, 
preparing to putenv() rewriting.

Unlike portable soft like gcc, cvs, etc. FreeBSD have a bad habbit 
considering putenv() arg as safe to pass and forget (because 
putenv() was incorrecly implemented via setenv(), which copy the arg), 
there still a lot of places to fix, almost every putenv() usage in FreeBSD 
is unportable... :(

-- 
http://ache.pp.ru/