From owner-freebsd-current Sun Oct 1 12:21: 0 2000 Delivered-To: freebsd-current@freebsd.org Received: from green.dyndns.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 881C537B503; Sun, 1 Oct 2000 12:20:55 -0700 (PDT) Received: from localhost (rjgdzw@localhost [127.0.0.1] (may be forged)) by green.dyndns.org (8.11.0/8.11.0) with ESMTP id e91JKk549150; Sun, 1 Oct 2000 15:20:49 -0400 (EDT) (envelope-from green@FreeBSD.org) Message-Id: <200010011920.e91JKk549150@green.dyndns.org> X-Mailer: exmh version 2.2 06/23/2000 with nmh-1.0.4 To: Mike Smith Cc: Jordan Hubbard , Michael Harnois , current@FreeBSD.org Subject: Re: Today -current broken on build In-Reply-To: Message from Mike Smith of "Sun, 01 Oct 2000 12:14:25 PDT." <200010011914.e91JEPh03548@mass.osd.bsdi.com> From: "Brian F. Feldman" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 01 Oct 2000 15:20:45 -0400 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Mike Smith wrote: > > > I hate to spoil the moment ... but does anyone have an idea what the > > > fix is? Nothing in the amd directory seems to have changed in the > > > past couple of weeks, so it must be somewhere else, and I'm not bright > > > enough to figure out where. > > > > Yeah, somebody forgot that typedefs and structure names can't > > conflict. :) I've just committed the fix. > > Er, this is probably the wrong fix. It sounds like the kernel 'callout' > structure is ending up visible in userland, which it shouldn't. Thing is, I for one can't figure out what just changed. I've been manually following all the ways sys/callout.h would be included, and none seem to apply here. For example, sys/systm.h isn't included in any way I can tell by this amd file, and sys/callout.h isn't explicitly either. This is really annoying. So, sys/callout.h should be in #ifdef _KERNEL #endif /* _KERNEL */, but I just can't find out what broke it in the first place so I didn't want to fix anything. It would be nice to have the system Mozilla uses for this where we can pinpoint automatically what commit broke things. -- Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / green@FreeBSD.org `------------------------------' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message