From nobody Fri Mar 24 19:41:15 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pjsyk6mdRz411my for ; Fri, 24 Mar 2023 19:41:18 +0000 (UTC) (envelope-from obiwac@gmail.com) Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pjsyk0PcKz3FPQ for ; Fri, 24 Mar 2023 19:41:18 +0000 (UTC) (envelope-from obiwac@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=lf19jlga; spf=pass (mx1.freebsd.org: domain of obiwac@gmail.com designates 2a00:1450:4864:20::534 as permitted sender) smtp.mailfrom=obiwac@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-x534.google.com with SMTP id x3so11972242edb.10 for ; Fri, 24 Mar 2023 12:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679686876; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=kIaLjVRJyVJ+LlL8n0GA9DZw3bN56leUY6djDqkEKsM=; b=lf19jlgaH+SEtgbWJvOCx/4heRpfI39cOr0Z+jWKhaoVhqGuYxASfWVdShEzOoRvph itMqP153nzpBgqFDdWwta2xl4MhLd6lcQ5Bl6f6Arx5GefTSzQphyuCupbxmAb9tBv4Y f4L+Zrlq+keZo3ldlIBnXm0i7cT1GPcsuez4hsLnMC3mEHcIPu7wnHPqR5Wi5sedZvV4 fKHdCoQrwUN5YlWJk5rhuHx4YC/v5nKdAAKG7y5GA0YrTSjX2v/N5FGxBCEpbggrLaCA 72s3+HKEQye0sh+rWBygUvHrvCVhAdSLxmlWZaZgBJA8TTtx6bSJbCvnZXzGKBKJYA4/ QThA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679686876; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kIaLjVRJyVJ+LlL8n0GA9DZw3bN56leUY6djDqkEKsM=; b=jv4qsdbUSxjZWr01EAoFyA1THh8A2ALkqcQs5dqT7xpas35FmXwUi0buJb9sV+CJik BzDHiFzP0WirdhT8bYg+cxo7IMHbLKPxG4a8T41WE2xTaXM2carYuSuHjxMsPTQPQDQH hGBHuNDXDODpXRhGkSEPYkIoUe2amCLVSKaD2keYAUZ/WyKNh4CqnlBdZ2q/CeWzrPy7 CwpwKiJ6CgMh8V8Nv5W16tlJJclUXUKWsYdA/qiOtFR0BVkQdGfiRdtxNIDEG7Altw8D FWTIE8C8Jc1RCVyWEbR76/cwqqcdnCcuddEJ1tpDhOH8tZMvc5rmeDoBf9GG5oj927M7 IeEg== X-Gm-Message-State: AAQBX9dvbnXnD7i85y+Isv/DlBv886dpBFT3ZyVPDQ4YezyAP/5dW2XH AVhGKaRV0XzElg9Tx4fM7CuzYkURDfGj5sSMLvRWq3L+ X-Google-Smtp-Source: AKy350YCZ96zUSyEvQaF26rfltNFg3loDBUp8r5dW4slwptvs1v/qotex1bSZgHetxV4NYq4VRzcMGhPo7B0PkmavTg= X-Received: by 2002:a50:a444:0:b0:500:5463:35de with SMTP id v4-20020a50a444000000b00500546335demr2115875edb.8.1679686876381; Fri, 24 Mar 2023 12:41:16 -0700 (PDT) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Received: by 2002:a17:907:d311:b0:8e7:7343:cad1 with HTTP; Fri, 24 Mar 2023 12:41:15 -0700 (PDT) From: obiwac Date: Fri, 24 Mar 2023 19:41:15 +0000 Message-ID: Subject: net80211 association failures in station mode To: freebsd-hackers Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [-3.48 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.48)[-0.485]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[freebsd-hackers@freebsd.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::534:from]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; ARC_NA(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; RCVD_COUNT_THREE(0.00)[3]; RCPT_COUNT_ONE(0.00)[1]; MID_RHS_MATCH_FROMTLD(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Rspamd-Queue-Id: 4Pjsyk0PcKz3FPQ X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N Hey, Recently I've been getting a lot of association failures with wpa_supplicant(8). I looked into things a little and found that the issue comes when iterating over the sta scan table with mlmelookup (sys/net80211/ieee80211_ioctl.c) in setmlme_assoc_sta, which first checks if the MAC addresses are equal between the query and a scan entry, and then checks if the SSID's are equal. (Minor issue but the "Match mac address and *any* ssid." comment above is wrong, right?) Thing is that query used when calling setmlme_assoc_sta (in ieee80211_ioctl_setmlme) is the vap's SSID (vap->iv_des_ssid[0]), whereas the one used when calling setmlme_assoc_adhoc for adhoc networks is the SSID contained in the MLME request structure (mlme.im_ssid): static int ieee80211_ioctl_setmlme(struct ieee80211vap *vap, struct ieee80211req *ireq) { struct ieee80211req_mlme mlme; ... int error = copyin(ireq->i_data, &mlme, sizeof(mlme)); ... if (vap->iv_opmode == IEEE80211_M_STA && mlme.im_op == IEEE80211_MLME_ASSOC) return setmlme_assoc_sta(vap, mlme.im_macaddr, vap->iv_des_ssid[0].len, vap->iv_des_ssid[0].ssid); else if ((vap->iv_opmode == IEEE80211_M_IBSS || vap->iv_opmode == IEEE80211_M_AHDEMO) && mlme.im_op == IEEE80211_MLME_ASSOC) return setmlme_assoc_adhoc(vap, mlme.im_macaddr, mlme.im_ssid_len, mlme.im_ssid); ... } I would have expected these SSID arguments be the other way around, because e.g. when wpa_supplicant(8) tries to associate in station mode, it sets the wanted SSID in the MLME request structure and then calls IEEE802_IOC_MLME - in fact, when reversing these arguments, I can associate no problem and things operate as I'd expect again... But since this code has last been touched over a decade ago, I feel like there's something I'm missing/doing wrong here :P If this is indeed wrong I'll make a diff :) Thanks in advance, Aymeric