From owner-freebsd-python@FreeBSD.ORG Mon Oct 1 17:51:38 2012 Return-Path: Delivered-To: python@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D41BE106566B; Mon, 1 Oct 2012 17:51:38 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 681E08FC0C; Mon, 1 Oct 2012 17:51:37 +0000 (UTC) Received: by vcbfw7 with SMTP id fw7so7736587vcb.13 for ; Mon, 01 Oct 2012 10:51:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=84/c3aYLiQPktY/T9uE0JEoJahHeLDXXpMW35iHMHGY=; b=HIXo4sh4DCftpJDDszd70Erl/GwSp20QnH40C7gWqOdRDDeRA/WYB/8mjDHSvvolDH F2xyarKsiwwkocUQkSMeSZ5XbTEUSGlKzSAL1j0D71AcLZc7lpm+4emhCt88goEZj7hW g8PRJJGXENuuXCPldNFhyU1xy1/NEdLYDg5tHHLOkRvXMKnUXCConrXhDUxokNrURMbu UoYM86HoCQpKgGKjRrpaVzcKYOH6gwpNFlAOjuAkh56IYdrnYw9vtm62NpxVArRq9G+g htYv1J9QkEEZEPqdiivb437yTWPhcjSk/aJPtaH6133H8TvBMj4dErLhsKl8p+wWRI7+ d1/Q== MIME-Version: 1.0 Received: by 10.58.179.39 with SMTP id dd7mr9109303vec.2.1349113897319; Mon, 01 Oct 2012 10:51:37 -0700 (PDT) Sender: lwhsu.freebsd@gmail.com Received: by 10.52.36.228 with HTTP; Mon, 1 Oct 2012 10:51:37 -0700 (PDT) In-Reply-To: <20121001161037.Horde.w6rVCKGZi1VQaaRdcWmiv-A@webmail.df.eu> References: <50698A96.4000301@yandex.ru> <20121001161037.Horde.w6rVCKGZi1VQaaRdcWmiv-A@webmail.df.eu> Date: Tue, 2 Oct 2012 01:51:37 +0800 X-Google-Sender-Auth: UsektKY86D-brjmZP7yQWJkUJUY Message-ID: From: Li-Wen Hsu To: Marcus von Appen Content-Type: text/plain; charset=UTF-8 Cc: python Subject: Re: Python distribution: switching to tar.xz X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2012 17:51:38 -0000 On Mon, Oct 1, 2012 at 10:10 PM, Marcus von Appen wrote: > > Ruslan Mahmatkhanov : > >> Hello, >> >> The python.org ftp provides lang/pythonXX source tarballs in a many >> formats: >> - tar.bz2 >> - tar.xz >> - tgz >> >> Using .tgz is not in sports-way this days, so I'd prefer to use tar.xz for >> new versions. But I can't actually choose there because tarball format is >> hardcoded in Mk/bsd.python.mk as PYTHON_DISTFILE variable: >> >> PYTHON_DISTFILE= >> Python-${PYTHON_PORTVERSION:S/.rc/rc/}.tgz >> >> And in particular python port we have this: >> >> DISTFILES= ${PYTHON_DISTFILE} >> >> Since I can't just choose tar.xz for some new python33 port, I suggest to >> change PYTHON_DISTFILE to use tar.xz and to change all the distinfos for >> lang/pythonXX (with changing SHA256/SIZE fields). What do you think? > > > I would rather see PYTHON_DISTFILE removed from bsd.python.mk and being > moved back > to the individual ports instead. Or, to stay compatible for whatever reason, > change > it to PYTHON_DISTFILE?= ..., so ports can override it. > > Or, even better in making things complicated, change it to > > PYTHON_DISTFILE = ${PYTHON_IMPLTYPE}_${PORTVERSION}${EXTRACT_SUFX} > I'm not sure introducing ${PYTHON_IMPLTYPE} is a good idea... but it might be good to change hard-coded .tgz: PYTHON_DISTFILE= Python-${PYTHON_PORTVERSION:S/.rc/rc/}.tgz to: EXTRACT_SUFX?= .tgz PYTHON_DISTFILE= Python-${PYTHON_PORTVERSION:S/.rc/rc/}}${EXTRACT_SUFX} then we can define USE_XZ= yes in the ports we want to use xz distfile, which handles ${EXTRACT_SUFX} and ${EXTRACT_DEPENDS} correctly. After python26 decommission, we can even move this into bsd.python.mk -- Li-Wen Hsu http://lwhsu.org