Date: Tue, 2 Oct 2012 01:51:37 +0800 From: Li-Wen Hsu <lwhsu@FreeBSD.org> To: Marcus von Appen <mva@freebsd.org> Cc: python <python@freebsd.org> Subject: Re: Python distribution: switching to tar.xz Message-ID: <CAKBkRUy2F_Lk4WM6wt-VqOptQLiURLxU0eUOOQ7puEteLSK3pA@mail.gmail.com> In-Reply-To: <20121001161037.Horde.w6rVCKGZi1VQaaRdcWmiv-A@webmail.df.eu> References: <50698A96.4000301@yandex.ru> <20121001161037.Horde.w6rVCKGZi1VQaaRdcWmiv-A@webmail.df.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 1, 2012 at 10:10 PM, Marcus von Appen <mva@freebsd.org> wrote:
>
> Ruslan Mahmatkhanov <cvs-src@yandex.ru>:
>
>> Hello,
>>
>> The python.org ftp provides lang/pythonXX source tarballs in a many
>> formats:
>> - tar.bz2
>> - tar.xz
>> - tgz
>>
>> Using .tgz is not in sports-way this days, so I'd prefer to use tar.xz for
>> new versions. But I can't actually choose there because tarball format is
>> hardcoded in Mk/bsd.python.mk as PYTHON_DISTFILE variable:
>>
>> PYTHON_DISTFILE=
>> Python-${PYTHON_PORTVERSION:S/.rc/rc/}.tgz
>>
>> And in particular python port we have this:
>>
>> DISTFILES= ${PYTHON_DISTFILE}
>>
>> Since I can't just choose tar.xz for some new python33 port, I suggest to
>> change PYTHON_DISTFILE to use tar.xz and to change all the distinfos for
>> lang/pythonXX (with changing SHA256/SIZE fields). What do you think?
>
>
> I would rather see PYTHON_DISTFILE removed from bsd.python.mk and being
> moved back
> to the individual ports instead. Or, to stay compatible for whatever reason,
> change
> it to PYTHON_DISTFILE?= ..., so ports can override it.
>
> Or, even better in making things complicated, change it to
>
> PYTHON_DISTFILE = ${PYTHON_IMPLTYPE}_${PORTVERSION}${EXTRACT_SUFX}
>
I'm not sure introducing ${PYTHON_IMPLTYPE} is a good idea... but it
might be good to
change hard-coded .tgz:
PYTHON_DISTFILE= Python-${PYTHON_PORTVERSION:S/.rc/rc/}.tgz
to:
EXTRACT_SUFX?= .tgz
PYTHON_DISTFILE= Python-${PYTHON_PORTVERSION:S/.rc/rc/}}${EXTRACT_SUFX}
then we can define USE_XZ= yes in the ports we want to use xz
distfile, which handles
${EXTRACT_SUFX} and ${EXTRACT_DEPENDS} correctly. After python26 decommission,
we can even move this into bsd.python.mk
--
Li-Wen Hsu
http://lwhsu.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKBkRUy2F_Lk4WM6wt-VqOptQLiURLxU0eUOOQ7puEteLSK3pA>