From owner-freebsd-qa Tue Dec 25 1:18:59 2001 Delivered-To: freebsd-qa@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id 60A9D37B416; Tue, 25 Dec 2001 01:18:56 -0800 (PST) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.6/8.11.6) with ESMTP id fBP9Gbl05072; Tue, 25 Dec 2001 10:16:43 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Jordan Hubbard Cc: Robert Watson , The Anarcat , re@freebsd.org, qa@freebsd.org, jkh@freebsd.org Subject: Re: regression tests for possible sysctl kern.disks/libdisk changes/mfc In-Reply-To: Your message of "Mon, 24 Dec 2001 19:03:52 PST." <40166.1009249432@winston.freebsd.org> Date: Tue, 25 Dec 2001 10:16:37 +0100 Message-ID: <5070.1009271797@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-qa@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <40166.1009249432@winston.freebsd.org>, Jordan Hubbard writes: >1. Nothing "broke", it simply confused the users significantly > that "da0" used to be the very first item in the disk selection > menu and then suddenly got shuffled to a different location in > that menu, rendering their muscle memory for that menu obsolete. > >2. The downsides are mostly that the code in libdisk doesn't get > to benefit from a cleaner way of getting disk info (the sysctl). > >3. The risks I can see is that the menu goes back to exhibiting the > funky behavior of before, but that's probably unlikely. I committed code to libdisk to sort the disks into alphabetical order, that should do the trick. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-qa" in the body of the message