Date: Mon, 29 Aug 2011 11:29:35 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Hans Petter Selasky <hselasky@FreeBSD.org> Cc: freebsd-arch@FreeBSD.org Subject: Re: skipping locks, mutex_owned, usb Message-ID: <4E5B4DEF.9050106@FreeBSD.org> In-Reply-To: <201108281127.44696.hselasky@freebsd.org> References: <4E53986B.5000804@FreeBSD.org> <4E5A099F.4060903@FreeBSD.org> <201108281127.44696.hselasky@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
on 28/08/2011 12:27 Hans Petter Selasky said the following:
> On Sunday 28 August 2011 11:25:51 Andriy Gapon wrote:
>> So many unconventional tricks.
>
> Similar code is used in the DROP_GIANT and PICKUP_GIANT macros.
Thank you for pointing this out - I was unfair to the USB code.
This changes my perspective of the mtx_owned issue a little bit...
OTOH, it looks like DROP_GIANT/PICKUP_GIANT are used in the code paths that
should not be exercised in the post-panic / dumping environment.
Except, perhaps, for the sync-on-panic option, which needs to be re-worked anyways.
> You might want
> to check all references to mtx_owned() in the kernel, and make a set of
> exceptions for post-panic code execution.
$ glimpse mtx_owned | wc -l
152
This looks like a too large plate for me :-(
--
Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E5B4DEF.9050106>