From owner-freebsd-bugs@FreeBSD.ORG Tue Aug 10 02:00:40 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D9BA516A4CE for ; Tue, 10 Aug 2004 02:00:38 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B4C6043D41 for ; Tue, 10 Aug 2004 02:00:38 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i7A20cgM090025 for ; Tue, 10 Aug 2004 02:00:38 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i7A20csp089982; Tue, 10 Aug 2004 02:00:38 GMT (envelope-from gnats) Resent-Date: Tue, 10 Aug 2004 02:00:38 GMT Resent-Message-Id: <200408100200.i7A20csp089982@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Matthew Luckie Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 66F0116A4CE for ; Tue, 10 Aug 2004 01:59:24 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5ED6B43D4C for ; Tue, 10 Aug 2004 01:59:24 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i7A1xN8Y088861 for ; Tue, 10 Aug 2004 01:59:23 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.12.11/8.12.11/Submit) id i7A1xNQi088858; Tue, 10 Aug 2004 01:59:23 GMT (envelope-from nobody) Message-Id: <200408100159.i7A1xNQi088858@www.freebsd.org> Date: Tue, 10 Aug 2004 01:59:23 GMT From: Matthew Luckie To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: kern/70236: uninitialised parameters passed to kernel_sysctl X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Aug 2004 02:00:40 -0000 >Number: 70236 >Category: kern >Synopsis: uninitialised parameters passed to kernel_sysctl >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Aug 10 02:00:38 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Matthew Luckie >Release: FreeBSD 4.10 >Organization: University of Waikato >Environment: FreeBSD lycra.luckie.org.nz 4.10-RELEASE-p2 FreeBSD 4.10-RELEASE-p2 #7: Wed Jul 28 08:39:51 NZST 2004 root@lycra.luckie.org.nz:/files/freebsd_src/sys/compile/lycra i386 >Description: I found two instances of kernel_sysctl being called without olen being set. >How-To-Repeat: N/A >Fix: --- sys/nwfs/nwfs_vfsops.c.orig Tue Aug 10 13:51:32 2004 +++ sys/nwfs/nwfs_vfsops.c Tue Aug 10 13:51:52 2004 @@ -394,6 +394,7 @@ name[0] = CTL_HW; name[1] = HW_NCPU; + olen = sizeof(ncpu); error = kernel_sysctl(curproc, name, 2, &ncpu, &olen, NULL, 0, &plen); if (error == 0 && ncpu > 1) printf("warning: nwfs module compiled without SMP support."); --- sys/netsmb/smb_subr.c.orig Tue Aug 10 13:49:14 2004 +++ sys/netsmb/smb_subr.c Tue Aug 10 13:50:14 2004 @@ -375,6 +375,7 @@ name[0] = CTL_HW; name[1] = HW_NCPU; + olen = sizeof(ncpu); error = kernel_sysctl(curproc, name, 2, &ncpu, &olen, NULL, 0, &plen); if (error) return error; >Release-Note: >Audit-Trail: >Unformatted: