From nobody Sun May 3 23:09:21 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g80pT5gvqz6cLKp for ; Sun, 03 May 2026 23:09:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g80pT2pDCz3Xls for ; Sun, 03 May 2026 23:09:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777849761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Svf1xg6vj6DSBIEBzJIfXj+SdU8tFpZCFc9wYaGskRw=; b=tIVLW/LmX2QJ6QXs1JZ0LRsHEneon7y1XEb3oz8QE4D+y4w0ekGLz0LC/EVl8DnfMyc6WV 0pzzEGJgCOrvB35L0dfCpVAyC5ywsJlzJm2iiewRl5ZLTpC6V4LJJkZUd6tkojwJvsJTcM l3odt8UzfYAA/zwhnf4yspOVQuZFEvthAia5KCFhkTToKLusKzQkfoDUUw9v0DoXwz9lrH gR/mVIDVZj1ZFSw7JMDGI+4DjASufzPywjUyjGd6rNyS65vtnD1IsV7y1+znz3/lxIC/j7 3v5DnYs/NLsGyFaj0BE+Q4gQvdy4vLBYfYL5QHJdmpl55AtkyedqSq9oHkqWUg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777849761; a=rsa-sha256; cv=none; b=vTBF0S4/YQ6GGwDh1t2u47/yaqdqjMOlEt8JUmu34nFjvILwkX/uWTIaorpe7/weO2qdrW hM7Wow3fOZqm9mZiZbUnHJxPx9iWqazo3UCQ2fZUD+adx5aaKt9NzvFgepmXBQxDrI1pJW +zIe6M71coWBPD11rLC52MfQySMnUZTb36fC+4ugUfJiopqWw7Hwpn1cPZ2zmcabz+CIAg 0ztfOIbFFmTg4gFuSgEEYjPGphROGyF3KowKY0kO56wPLAJ9MBODWa3L+sPxF713nLnXIZ yjDNkPthCk2Wstkh2uYG2bondww177v8FLQJiKDKkAqKPrs0M4IDbmnZOw1q1A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777849761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Svf1xg6vj6DSBIEBzJIfXj+SdU8tFpZCFc9wYaGskRw=; b=KkR0VHJNgT/jiQBTjwSu1Hd1Po1Rs1jgdS5p3sr5ZQCxR5Ho4JCkeZmnZNsUl/kCHKvliJ cCB7lJ7HNbPH6QaRGJQ5oOvVZ3JbKyImlKqGo5RQi2cG1pJ2fXpjk7u+6gkVaLOFSiX1M6 IDDjwTtnuVBKQ0ls3o72nm19oBUSMANUlJJziqaXVH2Lv70i/uwQavj/o1MZuCjqqeTVLH KJtwrfH+GaBFVGOrjXjEKMZOckVVnptM3Z5/Z77LYh/it7js9tSfWgBffqx8UH6sodSMAZ Uy3DgOrmfJkpZBF0QfL4UmVk1sbpdvn+2caahdLWD9AtxC3BARMsxJuEk3qRXA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g80pT26whztmx for ; Sun, 03 May 2026 23:09:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24ca7 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 03 May 2026 23:09:21 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 47ae0135d461 - main - tests/if_lagg: Minor improvements List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 47ae0135d461854b72b905ac77bf3e1f5b2868bc Auto-Submitted: auto-generated Date: Sun, 03 May 2026 23:09:21 +0000 Message-Id: <69f7d5a1.24ca7.59eba5c7@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=47ae0135d461854b72b905ac77bf3e1f5b2868bc commit 47ae0135d461854b72b905ac77bf3e1f5b2868bc Author: Mark Johnston AuthorDate: 2026-05-03 15:48:49 +0000 Commit: Mark Johnston CommitDate: 2026-05-03 21:51:50 +0000 tests/if_lagg: Minor improvements - Set require.kmods instead of relying on ifconfig to load if_lagg.ko, as this doesn't work when running within a jail. - Simplify helper functions which create tap and lagg devices. MFC after: 1 week --- tests/sys/net/if_lagg_test.sh | 35 +++++++++++------------------------ 1 file changed, 11 insertions(+), 24 deletions(-) diff --git a/tests/sys/net/if_lagg_test.sh b/tests/sys/net/if_lagg_test.sh index 992cdd1ebc0d..7351700b3b82 100755 --- a/tests/sys/net/if_lagg_test.sh +++ b/tests/sys/net/if_lagg_test.sh @@ -35,6 +35,7 @@ create_head() { atf_set "descr" "Create a lagg and assign an address" atf_set "require.user" "root" + atf_set "require.kmods" if_lagg } create_body() { @@ -78,6 +79,7 @@ status_stress_head() { atf_set "descr" "Simultaneously query a lagg while also creating or destroying it." atf_set "require.user" "root" + atf_set "require.kmods" if_lagg } status_stress_body() { @@ -133,6 +135,7 @@ create_destroy_stress_head() { atf_set "descr" "Simultaneously create and destroy a lagg" atf_set "require.user" "root" + atf_set "require.kmods" if_lagg } create_destroy_stress_body() { @@ -187,6 +190,7 @@ lacp_linkstate_destroy_stress_head() { atf_set "descr" "Simultaneously destroy an LACP lagg and change its childrens link states" atf_set "require.user" "root" + atf_set "require.kmods" if_lagg } lacp_linkstate_destroy_stress_body() { @@ -246,6 +250,7 @@ up_destroy_stress_head() { atf_set "descr" "Simultaneously up and destroy a lagg" atf_set "require.user" "root" + atf_set "require.kmods" if_lagg } up_destroy_stress_body() { @@ -303,6 +308,7 @@ set_ether_head() { atf_set "descr" "Set a lagg's ethernet address" atf_set "require.user" "root" + atf_set "require.kmods" if_lagg } set_ether_body() { @@ -341,6 +347,7 @@ updown_head() { atf_set "descr" "upping or downing a lagg ups or downs its children" atf_set "require.user" "root" + atf_set "require.kmods" if_lagg } updown_body() { @@ -418,35 +425,15 @@ atf_init_test_cases() # Creates a new tap(4) interface, registers it for cleanup, and echoes it get_tap() { - local TAPN=0 - while ! ifconfig tap${TAPN} create > /dev/null 2>&1; do - if [ "$TAPN" -ge 8 ]; then - atf_skip "Could not create a tap(4) interface" - else - TAPN=$(($TAPN + 1)) - fi - done - local TAPD=tap${TAPN} - # Record the TAP device so we can clean it up later - echo ${TAPD} >> "devices_to_cleanup" - echo ${TAPD} + ifconfig tap create > tap + cat tap | tee -a devices_to_cleanup } # Creates a new lagg(4) interface, registers it for cleanup, and echoes it get_lagg() { - local LAGGN=0 - while ! ifconfig lagg${LAGGN} create > /dev/null 2>&1; do - if [ "$LAGGN" -ge 8 ]; then - atf_skip "Could not create a lagg(4) interface" - else - LAGGN=$(($LAGGN + 1)) - fi - done - local LAGGD=lagg${LAGGN} - # Record the lagg device so we can clean it up later - echo ${LAGGD} >> "devices_to_cleanup" - echo ${LAGGD} + ifconfig lagg create > lagg + cat lagg | tee -a devices_to_cleanup } cleanup_tap_and_lagg()