Date: Wed, 23 Mar 2022 17:44:23 +0100 From: "Alfonso S. Siciliano" <alf.siciliano@gmail.com> To: Jessica Clarke <jrtc27@freebsd.org> Cc: "Alfonso S. Siciliano" <asiciliano@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 0e5c72c3cc54 - main - bsdinstall time: Replace dialog with bsddialog Message-ID: <20220323174423.ae4d8730ba9fb057f94c7dd5@gmail.com> In-Reply-To: <535DB523-150D-4663-934E-174AA639FB54@freebsd.org> References: <202203231557.22NFv7Ro095912@gitrepo.freebsd.org> <535DB523-150D-4663-934E-174AA639FB54@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 23 Mar 2022 16:01:04 +0000 Jessica Clarke <jrtc27@freebsd.org> wrote: Thank you for the report, > > bsdinstall time: Replace dialog with bsddialog > > > > Replace (LGPL) dialog utility with (BSD-2-Clause) bsddialog utility, > > 'dialog --calendar' is replaced by 'bsddialog --datebox' with same > > features but different User Interface. > > Different in what way?.. dialog --calendar draws a calendar (similar to cal(1) output) while bsddialog --datebox draws 3 forms "multi-selection" to choose yy/mm/dd, options and output are the same (at least for the needs of bsdinstall). To try with a recent CURRENT: % dialog --calendar test 0 0 % bsddialog --datebox test 0 0 Do you or some BASE-component need a perfect --calendar UI implementation? If yes, what is the priority? > > # Set date > > exec 3>&1 > > -DATE=$(dialog --backtitle 'FreeBSD Installer' \ > > - --title 'Time & Date' \ > > +DATE=$(bsddialog --backtitle 'FreeBSD Installer' \ > > + --title ' Date ' \ > > Why do these both have spaces around them? I honestly forgot if it is a typo or a choice (I like it). However, I checked you are right: all other titles have not spaces around so I'll open a new review to fix. Alfonso -- Alfonso S. Siciliano <alf.siciliano@gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220323174423.ae4d8730ba9fb057f94c7dd5>