From owner-svn-src-all@freebsd.org Mon Apr 20 16:57:29 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 240E92C7B08; Mon, 20 Apr 2020 16:57:29 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [176.58.89.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 495Xtc5Y6Xz4g0r; Mon, 20 Apr 2020 16:57:28 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 495Xtb1ls8z3lbm; Mon, 20 Apr 2020 16:57:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id O7p-FfR7_AiU; Mon, 20 Apr 2020 16:55:08 +0000 (UTC) Received: from garnet.daemonic.se (unknown [IPv6:2001:470:dca9:201:39ae:b103:6efc:d521]) by mail.daemonic.se (Postfix) with ESMTPSA id 495Xlh571Zz3mCs; Mon, 20 Apr 2020 16:51:28 +0000 (UTC) Subject: Re: svn commit: r360126 - head/sys/dev/evdev To: Justin Hibbits Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202004201617.03KGHHj7074077@repo.freebsd.org> <20200420113957.50d41308@titan.knownspace> From: Niclas Zeising Message-ID: Date: Mon, 20 Apr 2020 18:51:27 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200420113957.50d41308@titan.knownspace> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 495Xtc5Y6Xz4g0r X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.91 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.96)[-0.963,0]; ASN(0.00)[asn:36236, ipnet:176.58.89.0/24, country:US]; NEURAL_HAM_LONG(-0.95)[-0.948,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2020 16:57:29 -0000 On 2020-04-20 18:39, Justin Hibbits wrote: > On Mon, 20 Apr 2020 16:17:17 +0000 (UTC) > Niclas Zeising wrote: > >> Author: zeising (doc,ports committer) >> Date: Mon Apr 20 16:17:16 2020 >> New Revision: 360126 >> URL: https://svnweb.freebsd.org/changeset/base/360126 >> >> Log: >> Change kern.evdev.rcpt_mask to 12 by default >> >> Change kern.evdev.rcpt_mask from 3 to 12 by default. This makes us >> much more evdev-friendly, and will prevent everyone using xorg and >> wayland with evdev devices (the default) from needing to change this >> locally. >> powerpc32 still uses the old value for the keyboard part, becaues >> the adb keyboard driver used there is not evdev compatible. >> >> Reviewed by: wulf >> Approved by: wulf >> MFC after: 2 weeks >> X-MFC-Note: 12 only >> Relnotes: yes >> Differential Revision: https://reviews.freebsd.org/D24370 >> >> Modified: >> head/sys/dev/evdev/evdev.c >> >> Modified: head/sys/dev/evdev/evdev.c >> ============================================================================== >> --- head/sys/dev/evdev/evdev.c Mon Apr 20 16:14:44 2020 >> (r360125) +++ head/sys/dev/evdev/evdev.c Mon Apr 20 16:17:16 >> 2020 (r360126) @@ -66,7 +66,12 @@ enum evdev_sparse_result >> >> MALLOC_DEFINE(M_EVDEV, "evdev", "evdev memory"); >> >> -int evdev_rcpt_mask = EVDEV_RCPT_SYSMOUSE | EVDEV_RCPT_KBDMUX; >> +/* adb keyboard driver used on powerpc does not support evdev yet */ >> +#ifdef __powerpc__ > > This affects *all* powerpc, not just powerpc32. For just powerpc32, > you should have: > > #if defined(__powerpc__) && !defined(__powerpc64__) Ok, I wasn't aware of that, I'll fix it. > > But I'm curious, why not attach to sysmouse(4) and kbdmux(4)? What > breakage does that cause? I could maybe see not attaching to > sysmouse(4) by default, if the protocol isn't expressive enough, but > kbdmux(4) should be sufficient. Sysmouse hides features from evdev, so it's better to let xorg or wayland access the device directly. If both are enabled, you'll get double events, meaning double key presses when using USB devices: https://reviews.freebsd.org/D24370#538523 Regards -- Niclas Zeising