From owner-svn-src-head@FreeBSD.ORG  Wed Feb 24 15:52:18 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6A0BB106564A;
	Wed, 24 Feb 2010 15:52:18 +0000 (UTC)
	(envelope-from brooks@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 59B528FC19;
	Wed, 24 Feb 2010 15:52:18 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o1OFqIg4031294;
	Wed, 24 Feb 2010 15:52:18 GMT (envelope-from brooks@svn.freebsd.org)
Received: (from brooks@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id o1OFqI0l031292;
	Wed, 24 Feb 2010 15:52:18 GMT (envelope-from brooks@svn.freebsd.org)
Message-Id: <201002241552.o1OFqI0l031292@svn.freebsd.org>
From: Brooks Davis <brooks@FreeBSD.org>
Date: Wed, 24 Feb 2010 15:52:18 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r204278 - head/sys/kern
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Feb 2010 15:52:18 -0000

Author: brooks
Date: Wed Feb 24 15:52:18 2010
New Revision: 204278
URL: http://svn.freebsd.org/changeset/base/204278

Log:
  Don't inforce an upper bound on kern.ngroups.  The INT_MAX-1 limit was
  too high due to several overflows.  The actual limit is somewhere in the
  neighborhood of INT_MAX/4 on 64-bit machines, but most systems could not
  support such a limit due to a lack of memory and the cost of duplicate
  credentials.
  
  Reported by:	bde

Modified:
  head/sys/kern/subr_param.c

Modified: head/sys/kern/subr_param.c
==============================================================================
--- head/sys/kern/subr_param.c	Wed Feb 24 15:27:31 2010	(r204277)
+++ head/sys/kern/subr_param.c	Wed Feb 24 15:52:18 2010	(r204278)
@@ -240,8 +240,6 @@ init_param1(void)
 	TUNABLE_INT_FETCH("kern.ngroups", &ngroups_max);
 	if (ngroups_max < NGROUPS_MAX)
 		ngroups_max = NGROUPS_MAX;
-	if (ngroups_max > INT_MAX - 1)
-		ngroups_max = INT_MAX - 1;
 }
 
 /*