Date: Wed, 14 May 2014 19:33:01 -0400 From: Mathieu Arnold <mat@FreeBSD.org> To: Mark Felder <feld@freebsd.org>, Adam Weinberger <adamw@adamw.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Adam Weinberger <adamw@FreeBSD.org>, ports-committers@FreeBSD.org Subject: Re: svn commit: r353977 - head/security/py-fail2ban Message-ID: <83CA55EF6D43506115DE9896@atuin.in.mat.cc> In-Reply-To: <5D7360F1-ABE8-417C-B666-355611AD79AB@FreeBSD.org> References: <201405131830.s4DIUNGm023128@svn.freebsd.org> <5CC317FA-F4BD-40C4-ACD8-04AB16902C4A@FreeBSD.org> <805981A4-2E52-4C2A-B2B8-B751D484279A@adamw.org> <5D7360F1-ABE8-417C-B666-355611AD79AB@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
+--On 13 mai 2014 20:54:09 -0500 Mark Felder <feld@freebsd.org> wrote:
|
| On May 13, 2014, at 20:36, Adam Weinberger <adamw@adamw.org> wrote:
|
|> On 13 May 2014, at 17:12, Mark Felder wrote:
|>
|>> On May 13, 2014, at 13:30, Adam Weinberger <adamw@FreeBSD.org> wrote:
|>>
|>>>
|>>> post-install:
|>>> - @${MKDIR} ${STAGEDIR}${FAIL2BAN_DBDIR}
|>>> + @${MKDIR} ${STAGEDIR}${FAIL2BAN_DBDIR} ${STAGEDIR}/var/run/fail2ban
|>>> @${MKDIR} ${STAGEDIR}${DOCSDIR}
|>>> (cd ${WRKSRC}/ && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR})
|>>> .for file in fail2ban-client fail2ban-regex fail2ban-server fail2ban
|>>>
|>>
|>>
|>> Pkg ignores items in ${STAGEDIR}/var (and probably all of base), so
|>> this won't actually make it into a package. In fact, since the creation
|>> of the stage dir it won't even make it if installed from a port (as a
|>> package is created before being installed). Anything you need created
|>> for the port to run that must exist in base such as /var/run/,
|>> /var/db/, /var/log/, etc should be handled in the rc script
|>> start_precmd so it gets created if necessary just before the daemon is
|>> launched.
|>>
|>> Just drop something in like
|>>
|>> start_precmd=fail2ban_prestart
|>>
|>> fail2ban_prestart()
|>> {
|>> for i in run db; do
|>> if [ ! -d /var/${i}/fail2ban ]; then
|>> install -d -o fail2ban /dev/null /var/${i}/fail2ban
|>> fi
|>> done
|>> }
|>>
|>> (or more verbose, but two actions -- mkdir and then chown)
|>>
|>> and then you can remove those MKDIRs in post-install
|>
|> That part about pkg ignoring /var doesn't seem right... The .keep_me
|> files in /var/run/fail2ban and /var/db/fail2ban are installed by pkg, as
|> expected.
|>
|> Putting the stuff into the rc script seems like a good idea, but I'm
|> missing where the current version isn't working.
|>
|
| You're right; my wires were crossed. I believe what I was thinking of is
| that pkg won't track those dirs and tell you they are leftovers.
It tracks them all right, look at dns/bind10 (well, don't look at it if you
value your sanity), it's pkg_install that fails to see and use them.
--
Mathieu Arnold
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?83CA55EF6D43506115DE9896>