Date: Fri, 28 Mar 2014 13:54:53 -0700 From: Freddie Cash <fjwcash@gmail.com> To: "A.J. 'Fonz' van Werven" <freebsd@skysmurf.nl> Cc: Henry Hu <henry.hu.sh@gmail.com>, "freebsd-ports@freebsd.org" <freebsd-ports@freebsd.org> Subject: Re: Mysterious patches Message-ID: <CAOjFWZ7UxZJOMfEMwLCAjS=7ShjySrxmufvh9f=rKoDpFW9NMQ@mail.gmail.com> In-Reply-To: <20140328204754.GA5208@spectrum.skysmurf.nl> References: <20140328201121.GA2505@spectrum.skysmurf.nl> <CAEJt7hY1EqtU4ut0B9kb3prTrJaDri1gLMBXa38QCC4mNyRSvg@mail.gmail.com> <20140328204754.GA5208@spectrum.skysmurf.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 28, 2014 at 1:47 PM, A.J. 'Fonz' van Werven <freebsd@skysmurf.n=
l
> wrote:
> Henry Hu wrote:
>
> > They apply to src/raster-png.cxx and src/raster.cxx
>
> Note to self: look inside the actual patch files themselves, it says righ=
t
> there which files they apply to *oops*.
>
> However, this does leave me puzzled about the file names. If a patch
> applies to, say, src/foo/bar.c, shouldn't it be called
> files/patch-src__foo__bar.c? This is how it's described in the Porter's
> Handbook. Given a filename such as files/patch-png.cxx I would expect tha=
t
> patch to apply to a file ${WRKDIR}/png.cxx.
>
> What am I misunderstanding here?
>
> =E2=80=8BPatch file naming conventions are just that: conventions. It's=
not
carved in stone and enforced in the tools. The patch program looks at the
paths in the diff file to figure out which files need to be edited.
The naming convention for patch files has changed over the years. Maybe
this one is using an older convention? Or maybe it never followed one to
begin with?
Either way, it you take maintainership of the port, you can make it follow
the current patch file naming convention. ;)
=E2=80=8B
--=20
Freddie Cash
fjwcash@gmail.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOjFWZ7UxZJOMfEMwLCAjS=7ShjySrxmufvh9f=rKoDpFW9NMQ>