From owner-svn-src-all@freebsd.org  Tue Jun 26 07:11:01 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67F2310156ED;
 Tue, 26 Jun 2018 07:11:01 +0000 (UTC)
 (envelope-from royger@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 1CF9F834E2;
 Tue, 26 Jun 2018 07:11:01 +0000 (UTC)
 (envelope-from royger@freebsd.org)
Received: from localhost (94.red-83-39-197.dynamicip.rima-tde.net
 [83.39.197.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate) (Authenticated sender: royger)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 7626712075;
 Tue, 26 Jun 2018 07:11:00 +0000 (UTC)
 (envelope-from royger@freebsd.org)
Date: Tue, 26 Jun 2018 09:10:50 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <royger@freebsd.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Cc: rgrimes@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
Subject: Re: svn commit: r335629 - in head: share/man/man4 sys/dev/vt/hw/vga
Message-ID: <20180626071050.cywzvicvddomiceh@mac.bytemobile.com>
References: <201806250939.w5P9dGMA067104@repo.freebsd.org>
 <201806251543.w5PFhp8g099163@pdx.rh.CN85.dnsmgr.net>
 <20180626052127.GA19828@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180626052127.GA19828@FreeBSD.org>
User-Agent: NeoMutt/20180512
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jun 2018 07:11:01 -0000

On Tue, Jun 26, 2018 at 05:21:27AM +0000, Alexey Dokuchaev wrote:
> On Mon, Jun 25, 2018 at 08:43:51AM -0700, Rodney W. Grimes wrote:
> > > New Revision: 335629
> > > URL: https://svnweb.freebsd.org/changeset/base/335629
> > > 
> > > Log:
> > >   vt: add option to ignore NO_VGA flag in ACPI
> > >   
> > >   To workaround buggy firmware that sets this flag when there's actually
> > >   a VGA present.
> > >   
> > >   Reported and tested by:	Yasuhiro KIMURA <yasu@utahime.org>
> > >   Sponsored by:		Citrix Systems R&D
> > >   Reviewed by:		kib
> > >   Differential revision:	https://reviews.freebsd.org/D16003
> > 
> > It is generally best to avoid double negatives,
> > couldnt this of been better named? (hw.vga.acpi_force_vga)
> 
> Yes please; I get constantly confused when calculating negatives and
> often get them wrong.

This is specifically done to workaround a firmware bug where some
buggy firmwares set the NO_VGA flag in ACPI. So the option does
exactly what the name says, it ignores the NO_VGA flag in ACPI. IMO
acpi_force_vga is not as descriptive as the current name.

Roger.