From owner-cvs-src@FreeBSD.ORG  Tue Oct 30 22:16:47 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2B66716A418;
	Tue, 30 Oct 2007 22:16:47 +0000 (UTC)
	(envelope-from keramida@freebsd.org)
Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36])
	by mx1.freebsd.org (Postfix) with ESMTP id 7C03513C4AA;
	Tue, 30 Oct 2007 22:16:46 +0000 (UTC)
	(envelope-from keramida@freebsd.org)
Received: from kobe.laptop (dialup55.ach.sch.gr [81.186.70.55])
	(authenticated bits=128)
	by igloo.linux.gr (8.14.1/8.14.1/Debian-9) with ESMTP id l9ULxP8K000662
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Tue, 30 Oct 2007 23:59:35 +0200
Received: from kobe.laptop (kobe.laptop [127.0.0.1])
	by kobe.laptop (8.14.1/8.14.1) with ESMTP id l9ULxOCa001708;
	Tue, 30 Oct 2007 23:59:24 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Received: (from keramida@localhost)
	by kobe.laptop (8.14.1/8.14.1/Submit) id l9UKAbY0001464;
	Tue, 30 Oct 2007 22:10:37 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Date: Tue, 30 Oct 2007 22:10:36 +0200
From: Giorgos Keramidas <keramida@freebsd.org>
To: Mike Makonnen <mtm@freebsd.org>
Message-ID: <20071030201036.GA1413@kobe.laptop>
References: <200710290008.l9T08Odw067359@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200710290008.l9T08Odw067359@repoman.freebsd.org>
X-Hellug-MailScanner: Found to be clean
X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached,
	score=-4.142, required 5, autolearn=not spam, ALL_TRUSTED -1.80,
	AWL 0.26, BAYES_00 -2.60)
X-Hellug-MailScanner-From: keramida@freebsd.org
X-Spam-Status: No
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sbin/route route.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Oct 2007 22:16:47 -0000

On 2007-10-29 00:08, Mike Makonnen <mtm@freebsd.org> wrote:
> mtm         2007-10-29 00:08:24 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sbin/route           route.c
>   Log:
>   Fix an error in bit shifting logic for network addresses. The route
>   command would add incorrect routing entries if network numbers weren't
>   fully "spelled" out according to their class. For example:
>     # route add 128.0/16   (works)
>     # route add 128/16     (doesn't work)
>   [...]
>   Submitted by:   Nuno Antunes <nuno.antunes@gmail.com> (mostly)
>   MFC after:      1 week
>
>   Revision  Changes    Path
>   1.82      +24 -20    src/sbin/route/route.c

Thank you Mike!  Almost identical to the patch I was testing a while
back, including better netmask handling parts :-)

Nuno has also mentioned that `netstat -rn' gets things wrong; do you
have a WIP for that too?  Do you need help with testing?