From owner-freebsd-bugs  Sun May 20 20: 0:10 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 53A2937B43F
	for <freebsd-bugs@hub.freebsd.org>; Sun, 20 May 2001 20:00:02 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f4L302k18213;
	Sun, 20 May 2001 20:00:02 -0700 (PDT)
	(envelope-from gnats)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 2928D37B42C
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 20 May 2001 20:00:00 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f4L300k18182;
	Sun, 20 May 2001 20:00:00 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200105210300.f4L300k18182@freefall.freebsd.org>
Date: Sun, 20 May 2001 20:00:00 -0700 (PDT)
From: tom@wact.net
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: bin/27485: pkg_add -r segfaults when PACKAGEROOT set
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         27485
>Category:       bin
>Synopsis:       pkg_add -r segfaults when PACKAGEROOT set
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 20 20:00:02 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Tom Uffner
>Release:        current
>Organization:
>Environment:
FreeBSD discordia.uffner.com 5.0-CURRENT FreeBSD 5.0-CURRENT #2: Wed May  2 09:00:12 EDT 2001     tom@discordia.uffner.com:/usr/obj/usr/src/sys/DISCORDIA  i386
>Description:
see summary
>How-To-Repeat:
setenv PACKAGEROOT ftp://ftp3.FreeBSD.org/pub
pkg_add -r tkcvs

the values of PACKAGEROOT and the package fetched do not matter
it will happen regardless.
>Fix:
Index: main.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/pkg_install/add/main.c,v
retrieving revision 1.35
diff -c -w -r1.35 main.c
*** main.c      2001/04/26 06:48:59     1.35
--- main.c      2001/05/21 02:19:26
***************
*** 197,203 ****
        strcpy(sitepath, "ftp://ftp.FreeBSD.org");
  
      if (getenv("PACKAGEROOT"))
!       strcpy(sitepath, getenv("PACKAGEMIRRORROOT"));
      else
        strcat(sitepath, "/pub");
  
--- 197,203 ----
        strcpy(sitepath, "ftp://ftp.FreeBSD.org");
  
      if (getenv("PACKAGEROOT"))
!       strcpy(sitepath, getenv("PACKAGEROOT"));
      else
        strcat(sitepath, "/pub");

>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message