From owner-svn-src-stable-10@freebsd.org Wed Jan 13 16:35:17 2016 Return-Path: Delivered-To: svn-src-stable-10@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E669FA8133D; Wed, 13 Jan 2016 16:35:16 +0000 (UTC) (envelope-from mahrens@gmail.com) Received: from mail-lf0-x230.google.com (mail-lf0-x230.google.com [IPv6:2a00:1450:4010:c07::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 85A9F182E; Wed, 13 Jan 2016 16:35:16 +0000 (UTC) (envelope-from mahrens@gmail.com) Received: by mail-lf0-x230.google.com with SMTP id m198so111584098lfm.0; Wed, 13 Jan 2016 08:35:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=0PaSiGPpaE8b84sVr2wXhs5V5QKKZfVHjchFWqdLRQE=; b=TYwa26+P/lCJykXRn+57+6ZNLY5VIe1GQz9IDI1o/O7X9HEXC8Zu64puP+MiXN5wda NexVAZtrHby6SyFa1Q4CU8mnobhdswPnCjNpdgABVFWcjqEGfNhBB91PKvvdVk80lbQ7 5K9qqsusv7hiY9NWs0eqmHpf4ZcQp6kc6UQzD3rh4ZnGvPOaUXN3bzTgLRXFMESOkrED v1iRStl5Qx0MwHCEtwYHUoXnxudmrY/LUOl1TkMxyydhWMo3xfP5YpeZ+IPMpf/ysFck mwh8e5t9ZyfRsI0j40Iv8jw0JYjGAiu2K8QFCUtdjtGmorqNdpedoMlXcfRq0DzpmHiY mcFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=0PaSiGPpaE8b84sVr2wXhs5V5QKKZfVHjchFWqdLRQE=; b=fWP/OVh6QkGbu9nFHdFDTKu85XGRN/Y4gDFZDDaNaQleyP1ClMYUWUOZfNhpOY9oUc tpHIReiuEqr4p7bVP7+qQIwSufEQIvydP2TR6vfPQohpN5BqT49WB+of4MA8iYvDBOEP t1dBFnseAtj0CmAGHY9lETLhevKPR8ORscm03h41Pk11qcJYHxsRa3TlQCUFcsoMnCbs /7skWERmaKcesh1C3jjUjK0JSBP1Q3iv11NSbEKK96B2sK2pNHFRN1E3aOnRkNh/LW5w JmxtrrAY0Qf+uhU8zKNiZpAfotAl8nRXy57MEW1TJl1coqkY/5qM0fiwKlQS1mskeJh4 f72Q== X-Gm-Message-State: ALoCoQnOOdx0e70BeR6Yo+nNG88mSkbmB7QOYV93amatngHIBaH4UGTTdWAEqepUMhSED9GRDWhS0vmntX7SDMV3/ME68kbpjQ== MIME-Version: 1.0 X-Received: by 10.25.21.225 with SMTP id 94mr48412059lfv.159.1452702914256; Wed, 13 Jan 2016 08:35:14 -0800 (PST) Sender: mahrens@gmail.com Received: by 10.112.142.165 with HTTP; Wed, 13 Jan 2016 08:35:14 -0800 (PST) In-Reply-To: <8694B9BA-0F48-4D1E-9974-2C095FF519A8@bsdimp.com> References: <201601121638.u0CGc9cJ076217@repo.freebsd.org> <20160113131858.GN70867@zxy.spb.ru> <56967AA1.3050201@freebsd.org> <8694B9BA-0F48-4D1E-9974-2C095FF519A8@bsdimp.com> Date: Wed, 13 Jan 2016 08:35:14 -0800 X-Google-Sender-Auth: TJPOhugMRN0Q97zoepTjtWjGXes Message-ID: Subject: Re: svn commit: r293776 - stable/10/usr.sbin/fstyp From: Matthew Ahrens To: Warner Losh Cc: Allan Jude , Slawa Olhovchenkov , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2016 16:35:17 -0000 On Wed, Jan 13, 2016 at 8:32 AM, Warner Losh wrote: > > > On Jan 13, 2016, at 9:26 AM, Allan Jude wrote: > > > > On 2016-01-13 08:18, Slawa Olhovchenkov wrote: > >> On Tue, Jan 12, 2016 at 04:38:09PM +0000, Allan Jude wrote: > >> > >>> Author: allanjude > >>> Date: Tue Jan 12 16:38:09 2016 > >>> New Revision: 293776 > >>> URL: https://svnweb.freebsd.org/changeset/base/293776 > >>> > >>> Log: > >>> MFC: r284589 > >>> Add the ability to detect ZFS and GELI encrypted file systems to > fstyp(8) > >>> > >>> MFC: r284644 > >>> Fix GCC Warnings > >>> > >>> MFC: r284728 > >>> Only build ZFS support in absense of WITHOUT_ZFS > >> > >> What purpose for switch off ZFS support in case WITHOUT_ZFS? > >> > > > > If the user builds FreeBSD WITHOUT_CDDL or WITHOUT_ZFS, then they are > > requesting that we not build the ZFS code, so building it anyway would > > be against their wishes. The most likely reason they would request this > > is for license reasons. > > For x86, that may be true. For arm and mips platforms, ZFS is too much of= a > memory pig-dog to run on much of the kit we run on in that space. Turning > it > off is part of removing the type 2 muda from the system. > > In any event, the double negative is true. Don=E2=80=99t build ZFS when i= ts > absence has > been requested with WITHOUT_ZFS is correct. > Some of the confusion may be because this is not building ZFS - just support for detecting ZFS pools in fstyp. Which would be reasonable to do even if you are not building support for ZFS. However, the fstyp ZFS code relies on libzfs and libnvpair which are CDDL licensed. So if you did not build ZFS (or CDDL), the fstyp code could not work. --matt