From owner-svn-src-all@FreeBSD.ORG Tue Oct 21 20:55:50 2008 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EA3DF106569B; Tue, 21 Oct 2008 20:55:50 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 373848FC1E; Tue, 21 Oct 2008 20:55:50 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.local ([192.168.254.200]) (authenticated bits=0) by pooker.samsco.org (8.14.2/8.14.2) with ESMTP id m9LKtk8T091030; Tue, 21 Oct 2008 14:55:46 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <48FE41D2.90602@samsco.org> Date: Tue, 21 Oct 2008 14:55:46 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.13) Gecko/20080313 SeaMonkey/1.1.9 MIME-Version: 1.0 To: John Baldwin References: <200810211851.m9LIptwg006141@svn.freebsd.org> In-Reply-To: <200810211851.m9LIptwg006141@svn.freebsd.org> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=3.8 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r184135 - head/sys/dev/ata X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Oct 2008 20:55:51 -0000 John Baldwin wrote: > Author: jhb > Date: Tue Oct 21 18:51:55 2008 > New Revision: 184135 > URL: http://svn.freebsd.org/changeset/base/184135 > > Log: > Restore the default maximum segment size for the bus dma tag to 64k as it > is in 6.x and 7.x. The typo caused 64k transactions to be unnecessarily > split up into two PRD entries. > > Modified: > head/sys/dev/ata/ata-dma.c > > Modified: head/sys/dev/ata/ata-dma.c > ============================================================================== > --- head/sys/dev/ata/ata-dma.c Tue Oct 21 18:50:52 2008 (r184134) > +++ head/sys/dev/ata/ata-dma.c Tue Oct 21 18:51:55 2008 (r184135) > @@ -78,7 +78,7 @@ ata_dmainit(device_t dev) > ch->dma.unload = ata_dmaunload; > ch->dma.alignment = 2; > ch->dma.boundary = 65536; > - ch->dma.segsize = 63536; > + ch->dma.segsize = 65536; > ch->dma.max_iosize = 128 * DEV_BSIZE; > ch->dma.max_address = BUS_SPACE_MAXADDR_32BIT; > ch->dma.dma_slots = 6; Not having a multiple-of-512 transfer size is likely more responsible for data corruption than having a transfer size near 64k. Scott