Date: Fri, 28 Mar 2014 16:00:14 -0500 From: Brooks Davis <brooks@freebsd.org> To: "A.J. 'Fonz' van Werven" <freebsd@skysmurf.nl> Cc: Henry Hu <henry.hu.sh@gmail.com>, "freebsd-ports@freebsd.org" <freebsd-ports@freebsd.org> Subject: Re: Mysterious patches Message-ID: <20140328210014.GE12685@lor.one-eyed-alien.net> In-Reply-To: <20140328204754.GA5208@spectrum.skysmurf.nl> References: <20140328201121.GA2505@spectrum.skysmurf.nl> <CAEJt7hY1EqtU4ut0B9kb3prTrJaDri1gLMBXa38QCC4mNyRSvg@mail.gmail.com> <20140328204754.GA5208@spectrum.skysmurf.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
--mSxgbZZZvrAyzONB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Mar 28, 2014 at 09:47:54PM +0100, A.J. 'Fonz' van Werven wrote:
> Henry Hu wrote:
>=20
> > They apply to src/raster-png.cxx and src/raster.cxx
>=20
> Note to self: look inside the actual patch files themselves, it says right
> there which files they apply to *oops*.
>=20
> However, this does leave me puzzled about the file names. If a patch
> applies to, say, src/foo/bar.c, shouldn't it be called
> files/patch-src__foo__bar.c? This is how it's described in the Porter's
> Handbook. Given a filename such as files/patch-png.cxx I would expect that
> patch to apply to a file ${WRKDIR}/png.cxx.
>=20
> What am I misunderstanding here?
The rule hasn't been around forever. It's also inappropriate for some
types of patches that apply to multiple files and might be removed
later. The warning patch is a boarderline example of the latter, but I
use the pattern in the clang and llvm ports for patches pulled from the
upstream svn repo.
New ports should follow the rule where it makes sense, but renaming
files used to be annoyingly expensive so older ports were typically left
alone.
-- Brooks
--mSxgbZZZvrAyzONB
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)
iKYEARECAGYFAlM14t1fFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl
bnBncC5maWZ0aGhvcnNlbWFuLm5ldDY1NUQ1MTlDMjZBNzgyRTcyNTI5OUJGMDVE
OEU4QkU5RjIzODFBRDQACgkQXY6L6fI4GtTHXACeP1cIf69xVQdFhi4cRPEOS8Cw
EKIAn3CjXqj7JYJrZUXpG3R755a3qnbZ
=tZ1s
-----END PGP SIGNATURE-----
--mSxgbZZZvrAyzONB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140328210014.GE12685>