From owner-freebsd-arch@freebsd.org Fri Nov 8 07:07:20 2019 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8DC6F1A93EC for ; Fri, 8 Nov 2019 07:07:20 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 478WYM4hLkz3yLV for ; Fri, 8 Nov 2019 07:07:19 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id SyMWiwqMK17ZDSyMXi4wRR; Fri, 08 Nov 2019 00:07:18 -0700 X-Authority-Analysis: v=2.3 cv=ZsqT1OzG c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=MeAgGD-zjQ4A:10 a=YxBL1-UpAAAA:8 a=9qa3YWOjAAAA:8 a=e5mUnYsNAAAA:8 a=6I5d2MoRAAAA:8 a=FRhivEZ415G1AZWOgI0A:9 a=72nkV6eZp--yWH3R:21 a=ii-7F7qYFb89p7Ku:21 a=CjuIK1q_8ugA:10 a=N6PBoGjP6LMA:10 a=2_lZy0vNFpoA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=2Su-2_OBkbdmYqucsK2F:22 a=Vxmtnl_E_bksehYqCbjh:22 a=IjZwj45LgO3ly-622nXo:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id 8CCE21682; Thu, 7 Nov 2019 23:07:15 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id xA876tgs045066; Thu, 7 Nov 2019 23:06:55 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id xA876tSG045063; Thu, 7 Nov 2019 23:06:55 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201911080706.xA876tSG045063@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Warner Losh cc: Cy Schubert , freebsd-arch@freebsd.org Subject: Re: Creating /etc/os-release In-reply-to: References: <201911080623.xA86NCcO070007@slippy.cwsent.com> Comments: In-reply-to Warner Losh message dated "Thu, 07 Nov 2019 23:37:29 -0700." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 07 Nov 2019 23:06:55 -0800 X-CMAE-Envelope: MS4wfIKIlXxsA7WLL4NARIpZDTwcdGimzS39ioSHry4ZUseyeRXBCnD/09l9WcSTWhR2VDpyAUcoQUv7VsqzhwSTU+lUacMnbdP4ckbgAMn9574sOi2ed/RG U6ShRweLnngTagns9QW92sCm0ln5d6iCqpR2r8GYsolaZC44Cr9Wfw4gUpACjyVb1x8w53/hhJR3EmJapbx8qYjkTgqEiraQ9w0= X-Rspamd-Queue-Id: 478WYM4hLkz3yLV X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 64.59.136.137) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-3.94 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; REPLYTO_EQ_FROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_SPF_NA(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[137.136.59.64.list.dnswl.org : 127.0.5.1]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-2.24)[ip: (-5.76), ipnet: 64.59.128.0/20(-3.02), asn: 6327(-2.33), country: CA(-0.09)]; FROM_EQ_ENVFROM(0.00)[] X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Nov 2019 07:07:20 -0000 In message , Warner Losh writes: > --000000000000c332a50596d00425 > Content-Type: text/plain; charset="UTF-8" > > On Thu, Nov 7, 2019, 11:23 PM Cy Schubert wrote: > > > In message > > > om> > > , Warner Losh writes: > > > Greetings, > > > > > > A standard has evolved in other communities to communicate certain key > > > aspects of the system to interested parties. The /etc/os-release file. > > The > > > standard is defined here http://0pointer.de/blog/projects/os-release and > > > here https://www.freedesktop.org/software/systemd/man/os-release.html . > > It > > > has become a de-facto standard for the graphical systems. > > > > > > FreeBSD currently tries to address this with a port > > > sysutils/etc_os-release, but there's a number of issues with it, see for > > > example https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238953. The > > > biggest issue being that we can't install a static file: it has to change > > > as the system is updated. > > > > > > To that end, I propose the following: First, we create a /etc/os-release > > > symlink to /var/run/os-release. This will place the file in the standard > > > place, but allow its generation on each boot in a friendly to > > > read-only-root manner. Second, we create a /etc/rc.d/os-release script > > that > > > will populate /var/run/os-release. Since this is a standard rc script, we > > > can allow people to opt-out of generating this file in a standardized way > > > (although it contains information that's available to anybody on the > > > system, some reduced configurations may not have all the scripts / > > programs > > > used to generate it). If the file isn't generated, then opening it will > > > return the same not found error as before. Since this is a symlink, it's > > > friendly to etcupdate / mergemaster updating schemes. Finally, we'd > > > obsolete the port since it is flawed anyway. > > > > > > I opted for every boot rather than a file in /etc that gets generated as > > > part of mergemaster / etcupdate because it's more robust (the change > > > happens right away, and works in all environments, even if /etc isn't > > > updated). The amount of work here is tiny as well, so all but the most > > > demanding of users won't notice it at all. While this does come from the > > > Linux community, it has become a de-facto standard. DragonflyBSD has it, > > > for example, since 9c172c37, but their implementation is flawed for us to > > > use directly since it creates it at installworld time and we don't touch > > > /etc as part of installworld. We also have a port, but there's enough > > flaws > > > in the port approach that we should just make this be part of the base > > > system to place nicely with software that expects it today. It also means > > > we don't need hacks for freebsd-update. Finally, since this change is > > > additive, we can also MFC it to 12. > > > > > > I've created a change that I think covers all these aspects. Please see > > > https://reviews.freebsd.org/D22271 for the specifics. Comments about the > > > code should go there, while comments about the plan should go here. > > > > And, with pkgbase, assign it the actual release of the O/S so that we can > > do pkg info -aI | grep ... similar to rpm -aq | grep ... Why? Automation > > such as HP SA, Tower, cfengine, and others could be used to query package > > names in a mysql or Oracle database of packages. One could write an sql > > query to display all servers in a network with, for examle, package > > freebsd-12.1 (or whatever we choose to call it) installed. > > > > Of course this wouldn't work with -current or -stable unless installworld > > generates the appropriate package registrations at the time. Users of > > binary releases based on -RELEASE might see immediate benefit though. This > > might help integration into large shops -- making FreeBSD more visible to > > shops at the enterprise level -- which use that sort of automation. > > > It seems like pkg info would need some careful thought to know what to > report to maximize the benefits of the automation you want. It seems to me > you'd want more exact version info than what's customary for os-release. It > isn't clear to me the needs of this file from a compatibility with other > systems standpoint match well with what rpm -aq reports that you'd like pkg > to report. It's a good idea, but I'm having trouble connecting the dots > with the problem I'm trying to solve here. Using Red Hat as an example, IIRC they put the version.release numbers in the package name, or in the case of CentOS, a build number, followed by the repo name (el7 -- which I think is redundant), followed by the arch. We could have something like FreeBSD-12.1-r353000.amd64. If we want to maintain repositories for 12-stable and 12.1-release then something like FreeBSD-12.1.12S-r353000 for the -stable repo v.s. FreeBSD-12.1p3.12R for the same package within the 12-release repo. We don't need to decide the composition of the package name here and now but the folks working on pkgbase might want to have some input into this. Personally, I'm not set on one package name v.s. another, as long as we consider how we derive the file's package name in our installworld and release process. Contrary to how we'd normally consider what to do, in this case how it's done is probably more important than what the name is, as whatever decisions are made now in how we implement this, we will have to live with those decisions in the future. At this point how we do it is more important than the composition of the package name itself. I'd invite the pkgbase team for their thoughts. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.