From owner-cvs-src@FreeBSD.ORG Thu Feb 9 09:13:16 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E94D16A420; Thu, 9 Feb 2006 09:13:16 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id F25F843D79; Thu, 9 Feb 2006 09:13:09 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.3/8.13.3) with ESMTP id k199D8BG074796 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 9 Feb 2006 12:13:08 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.3/8.13.1/Submit) id k199D85X074795; Thu, 9 Feb 2006 12:13:08 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Thu, 9 Feb 2006 12:13:07 +0300 From: Gleb Smirnoff To: Qing Li , jeff@FreeBSD.org Message-ID: <20060209091307.GY877@FreeBSD.org> References: <200602082332.k18NWwN2039341@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200602082332.k18NWwN2039341@repoman.freebsd.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet tcp_syncache.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2006 09:13:16 -0000 On Wed, Feb 08, 2006 at 11:32:58PM +0000, Qing Li wrote: Q> qingli 2006-02-08 23:32:58 UTC Q> Q> FreeBSD src repository Q> Q> Modified files: Q> sys/netinet tcp_syncache.c Q> Log: Q> Redo the previous fix by setting the UMA_ZONE_ZINIT bit in the syncache Q> zone, eliminating the need to call bzero() after each syncache entry Q> allocation. UMA_ZONE_ZINIT flag for uma_zcreate() sets zone zinit method to bzero. I suggested to use M_ZERO flag for uma_zalloc(). I'm not sure this is correct, so I'm asking Jeff for clarification. AFAIU from uma(9) manpage the zinit method is called on the first allocation. But when an item is freed and is put to uma cache, next uma_zalloc() will just return it from cache. If there is a ctor method, it would be called on every allocation, but not zinit method. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE