From owner-freebsd-stable@FreeBSD.ORG  Wed Aug 13 13:43:12 2003
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6FDD337B401; Wed, 13 Aug 2003 13:43:12 -0700 (PDT)
Received: from bricore.com (adsl-64-168-71-68.dsl.snfc21.pacbell.net
	[64.168.71.68])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A6D8B43FB1; Wed, 13 Aug 2003 13:43:11 -0700 (PDT)
	(envelope-from lchen@briontech.com)
Received: from lchenpc (lchen-pc.bricore.com [192.168.1.130])
	(authenticated bits=0)
	by bricore.com (8.12.6/8.12.6) with ESMTP id h7DKh8v2072333;
	Wed, 13 Aug 2003 13:43:08 -0700 (PDT)
	(envelope-from lchen@briontech.com)
From: "Luoqi Chen" <lchen@briontech.com>
To: "Ruslan Ermilov" <ru@FreeBSD.org>
Date: Wed, 13 Aug 2003 13:42:26 -0700
Message-ID: <AHEKICEOIHLOGINAFIINIEDLCBAA.lchen@briontech.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0)
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165
In-Reply-To: <20030813200325.GA19717@sunbay.com>
Importance: Normal
X-Virus-Scanned: by amavisd-milter (http://amavis.org/)
cc: stable@FreeBSD.org
Subject: RE: [releng_4 tinderbox] failure on i386/i386
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Production branch of FreeBSD source code
	<freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Aug 2003 20:43:12 -0000

> This is due to your latest change to src/sys/conf/Makefile.i386
> in RELENG_4.
> 
> The problem is that when compiling LINT, the DIAGNOSTIC option
> is defined in opt_global.h, and null_subr.c attempts to include
> opt_ddb.h which doesn't exist.  The version in HEAD (kern.*.mk)
> doesn't do this.  Is this change really necessary for PAE?
>
For options like PAE, it's crucial for the module build process
to see them, otherwise the compiled binaries are useless, which
defeats the purpose of building the modules along with the kernel.
That said, I probably shouldn't have lumped this change with the PAE
commit.

On the other hand, all modules should create all the opt_*.h files
it needs when built individually. Add opt_ddb.h to nullfs's Makefile
should fix the breakage.

-lq

> 
> Cheers,
> -- 
> Ruslan Ermilov		Sysadmin and DBA,
> ru@sunbay.com		Sunbay Software Ltd,
> ru@FreeBSD.org		FreeBSD committer
>