From owner-freebsd-bugs Tue Dec 11 9:32:44 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id CE41037B7C8 for ; Tue, 11 Dec 2001 09:30:01 -0800 (PST) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id fBBHU1C78604; Tue, 11 Dec 2001 09:30:01 -0800 (PST) (envelope-from gnats) Date: Tue, 11 Dec 2001 09:30:01 -0800 (PST) Message-Id: <200112111730.fBBHU1C78604@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Peter Pentchev Subject: Re: misc/32687: scripts in /usr/local/etc/rc.d not executed in 4.4-STABLE Reply-To: Peter Pentchev Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR misc/32687; it has been noted by GNATS. From: Peter Pentchev To: Sheldon Hearn Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: misc/32687: scripts in /usr/local/etc/rc.d not executed in 4.4-STABLE Date: Tue, 11 Dec 2001 19:05:35 +0200 On Tue, Dec 11, 2001 at 07:00:07PM +0200, Sheldon Hearn wrote: > > > On Tue, 11 Dec 2001 18:51:49 +0200, Peter Pentchev wrote: > > > This makes sense. How about the attached patch? > > The warning message clutters the output, though; it almost certainly > > overflows to the next line on the screen, not to mention overflowing > > the 80-character source line.. I am thinking of shortening it somehow, > > maybe you or somebody else could suggest another wording? > > I'd suggest removing the warning altogether. Anyone who's managed to > mangle things in a 4.5-RELEASE upgrade to the point where they see this > message is unlikely to know how to make it go away. > > I like the rest of the patch. :-) Okay; the warning was actually an afterthought :) If nobody objects, I will commit the attached patch tomorrow morning (my morning, about twelve hours from now :) G'luck, Peter -- If the meanings of 'true' and 'false' were switched, then this sentence wouldn't be false. Index: src/etc/rc =================================================================== RCS file: /home/ncvs/src/etc/rc,v retrieving revision 1.287 diff -u -r1.287 rc --- src/etc/rc 11 Dec 2001 08:21:45 -0000 1.287 +++ src/etc/rc 11 Dec 2001 17:04:51 -0000 @@ -813,6 +813,9 @@ *) echo -n 'Local package initialization:' slist="" + if [ -z "${script_name_sep}" ]; then + script_name_sep=" " + fi for dir in ${local_startup}; do if [ -d "${dir}" ]; then for script in ${dir}/*.sh; do Index: src/etc/rc.shutdown =================================================================== RCS file: /home/ncvs/src/etc/rc.shutdown,v retrieving revision 1.20 diff -u -r1.20 rc.shutdown --- src/etc/rc.shutdown 24 Nov 2001 16:12:03 -0000 1.20 +++ src/etc/rc.shutdown 11 Dec 2001 17:04:52 -0000 @@ -103,6 +103,9 @@ ;; *) slist="" + if [ -z "${script_name_sep}" ]; then + script_name_sep=" " + fi for dir in ${local_startup}; do if [ -d "${dir}" ]; then for script in ${dir}/*.sh; do To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message