Date: Mon, 7 Nov 2005 10:54:09 GMT From: skv@FreeBSD.org To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/88590: archivers/libunrar: respect CXX/LDFLAGS Message-ID: <200511071054.jA7As9pL048392@freefall.freebsd.org> Resent-Message-ID: <200511071100.jA7B0NF3048631@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 88590
>Category: ports
>Synopsis: archivers/libunrar: respect CXX/LDFLAGS
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Nov 07 11:00:23 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Sergey Skvortsov
>Release: FreeBSD 4.11-STABLE i386
>Organization:
<Organization of PR author (multiple lines)>
>Environment:
<Relevant environment information (multiple lines)>
>Description:
Respect CXX/LDFLAGS accordingly to "Porter's Handbook".
>How-To-Repeat:
<Code/input/activities to reproduce the problem (multiple lines)>
>Fix:
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/archivers/libunrar/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- Makefile 11 Oct 2005 21:57:40 -0000 1.3
+++ Makefile 7 Nov 2005 06:49:57 -0000
@@ -22,6 +22,7 @@
USE_GMAKE= yes
MAKEFILE= makefile.unix
+MAKE_ENV+= CXX="${CXX}" LDFLAGS="${LDFLAGS}"
ALL_TARGET= lib
INSTALLS_SHLIB= yes
Index: files/patch-makefile.unix
===================================================================
RCS file: /home/ncvs/ports/archivers/libunrar/files/patch-makefile.unix,v
retrieving revision 1.1
diff -u -r1.1 patch-makefile.unix
--- files/patch-makefile.unix 23 Sep 2005 19:58:44 -0000 1.1
+++ files/patch-makefile.unix 7 Nov 2005 06:54:01 -0000
@@ -1,9 +1,10 @@
--- makefile.unix.orig Sat Apr 30 04:00:12 2005
+++ makefile.unix Fri Sep 23 16:22:04 2005
-@@ -7,9 +7,10 @@
+@@ -6,10 +6,10 @@
+ #
# Linux using GCC
- CXX=g++
+-CXX=g++
-CXXFLAGS=-O2
-DEFINES=-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
+CXXFLAGS=$(CFLAGS) -fPIC -DPIC
@@ -13,7 +14,7 @@
# Linux using LCC
#CXX=lcc
-@@ -86,7 +87,7 @@
+@@ -86,7 +86,7 @@
LINK=$(CXX)
UNRAR_OBJ=filestr.o recvol.o rs.o scantree.o
@@ -22,7 +23,7 @@
OBJECTS=rar.o strlist.o strfn.o pathfn.o int64.o savepos.o global.o file.o filefn.o filcreat.o \
archive.o arcread.o unicode.o system.o isnt.o crypt.o crc.o rawread.o encname.o \
-@@ -114,6 +115,12 @@
+@@ -114,6 +114,12 @@
$(STRIP) default.sfx
lib: WHAT=RARDLL
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200511071054.jA7As9pL048392>