From nobody Mon Dec 20 17:28:50 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id AEFDA18FA599; Mon, 20 Dec 2021 17:28:57 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4JHmlr75C8z4T0r; Mon, 20 Dec 2021 17:28:56 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 3D4BE3C0199; Mon, 20 Dec 2021 17:28:50 +0000 (UTC) Date: Mon, 20 Dec 2021 17:28:50 +0000 From: Brooks Davis To: Hans Petter Selasky Cc: Shawn Webb , Brooks Davis , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 45b48cbc2b58 - main - usb: real freebsd32 support for most ioctls Message-ID: <20211220172850.GA78726@spindle.one-eyed-alien.net> References: <202112172128.1BHLSvgR063035@gitrepo.freebsd.org> <20211218190800.2v7bzacypzhiguvz@mutt-hbsd> <4961aa77-848f-ab04-91aa-7526ebb0bdde@selasky.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GvXjxJ+pjyke8COw" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 4JHmlr75C8z4T0r X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of brooks@spindle.one-eyed-alien.net has no SPF policy when checking 199.48.129.229) smtp.mailfrom=brooks@spindle.one-eyed-alien.net X-Spamd-Result: default: False [-3.80 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FREEFALL_USER(0.00)[brooks]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[freebsd.org]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.90)[-0.905]; SIGNED_PGP(-2.00)[]; FORGED_SENDER(0.30)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; RCVD_COUNT_ZERO(0.00)[0]; R_SPF_NA(0.00)[no SPF record]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US]; FROM_NEQ_ENVFROM(0.00)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net] X-ThisMailContainsUnwantedMimeParts: N --GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 18, 2021 at 09:33:51PM +0100, Hans Petter Selasky wrote: > On 12/18/21 21:13, Hans Petter Selasky wrote: > > On 12/18/21 20:08, Shawn Webb wrote: > >> +#ifdef COMPAT_FREEBSD32 > >> +?????? hgd =3D (struct hidraw_gen_descriptor *)addr; > >=20 > > Looks like this line should be moved before the COMPAT_FREEBSD32 ifdef.= =20 > > I'll let Brooks fix this. > >=20 > > --HPS > >=20 >=20 > I've made two fixes. Brooks, please check these patches too: >=20 > https://cgit.freebsd.org/src/commit/?id=3D34077a8ed39f40da4b7faffff0b112f= 1dcb62ab4 >=20 > https://cgit.freebsd.org/src/commit/?id=3D8b60419b798ae9049988c529e6af3f3= 13a5cce55 Thank you for making these fixes. I'm a bit surprised neither of these showed up on amd64. :( -- Brooks --GvXjxJ+pjyke8COw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJhwL1RAAoJEKzQXbSebgfAVHYIAKS4V23PSu2VDqRcecXfYvUr +E9DlWzf/JRSn4VY5vNcrzXAULRJpb5+KkcIUbinfY18KvNRduUOiwTvO6Rij0II R0f61IbkTX0A5ikXqx5Uz9EGU/q0sYC5Mp812kyuFaVZvos8I4nqv9bE1ri7vGFI XbV9Es2nM3+4Ff9S9hT5UI/R+Q3qbrZ1NpzmKkk6UYbq+qEahi6llYPWURggsSsP ip707yYtmCnb+/wznHTkcUOliOwsDL7L/V/3LD8jO2QBN7JwonxxRVIIz2L/0DG4 G1cvEeBsp/ZdEEjT+Q/ZAks7M/YWLGfQgXlrTr2CtT8+XNjDZwrn/uZyd+/Jnc0= =/PKg -----END PGP SIGNATURE----- --GvXjxJ+pjyke8COw--