From owner-freebsd-fs@FreeBSD.ORG Mon Mar 22 06:52:45 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A07D6106566C for ; Mon, 22 Mar 2010 06:52:45 +0000 (UTC) (envelope-from kkockro@web.de) Received: from mail.myphotobook.de (mail.myphotobook.de [85.237.87.140]) by mx1.freebsd.org (Postfix) with ESMTP id DEB398FC16 for ; Mon, 22 Mar 2010 06:52:44 +0000 (UTC) Received: (qmail 66393 invoked by uid 89); 22 Mar 2010 06:25:42 -0000 Received: from unknown (HELO ) (k.kockro@myphotobook.de@87.234.224.68) by mail.myphotobook.de with AES256-SHA encrypted SMTP; 22 Mar 2010 06:25:42 -0000 From: Kai Kockro To: Rick Macklem Date: Mon, 22 Mar 2010 07:26:05 +0100 User-Agent: KMail/1.12.4 (FreeBSD/8.0-STABLE; KDE/4.3.5; amd64; ; ) References: <201003171120.o2HBK3CV082081@freefall.freebsd.org> <86tys9eqo6.fsf@kopusha.onet> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Message-Id: <201003220726.05291.kkockro@web.de> Cc: bug-followup@freebsd.org, freebsd-fs@freebsd.org, danny@cs.huji.ac.il Subject: Re: kern/144330: [nfs] mbuf leakage in nfsd with zfs X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2010 06:52:45 -0000 I will test it tonight on our ZFS Storages. kai Am Montag, 22. M=E4rz 2010 01:23:02 schrieb Rick Macklem: > On Sun, 21 Mar 2010, Mikolaj Golub wrote: > > Reviewing rpc/svc.c:svc_getreq() it looks for me that for RS_DONE case > > args are nevere freed. Shouldn't it be like in the attached patch? >=20 > Oops, I meant to ask Daniel Braniss (not Jeremy) w.r.t testing the patch, > since he can easily reproduce the problem. Of course, I'd appreciate > anyone who can test it to do so and let us know how it goes. >=20 > Daniel, here's the patch just in case you didn't see Mikolaj's email. >=20 > rick > Mikolaj's patch: > --- sys/rpc/svc.c.orig 2010-03-21 10:17:20.000000000 +0200 > +++ sys/rpc/svc.c 2010-03-21 10:20:05.000000000 +0200 > @@ -819,6 +819,7 @@ svc_getreq(SVCXPRT *xprt, struct svc_req > free(r->rq_addr, M_SONAME); > r->rq_addr =3D NULL; > } > + m_freem(args); > goto call_done; >=20 > default: >=20