From owner-freebsd-ports Wed Mar 29 11:58: 0 2000 Delivered-To: freebsd-ports@freebsd.org Received: from rock.ghis.net (rock.ghis.net [209.222.164.7]) by hub.freebsd.org (Postfix) with ESMTP id 66CE937C1D6; Wed, 29 Mar 2000 11:57:23 -0800 (PST) (envelope-from will@blackdawn.com) Received: from argon.blackdawn.com (03-181.dial.008.popsite.net [209.69.196.181]) by rock.ghis.net (8.9.3/8.9.3) with ESMTP id LAA22881; Wed, 29 Mar 2000 11:56:54 -0800 (PST) Received: by argon.blackdawn.com (Postfix, from userid 1000) id 834F51A50; Wed, 29 Mar 2000 14:56:15 -0500 (EST) Date: Wed, 29 Mar 2000 14:56:15 -0500 From: Will Andrews To: Kris Kennaway Cc: will@FreeBSD.org, reg@shale.csir.co.za, freebsd-ports@FreeBSD.org, asami@FreeBSD.org Subject: Re: ports/16343: bsd.port.mk cannot override make.conf. Message-ID: <20000329145615.C55527@argon.blackdawn.com> References: <200003282158.NAA73989@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: ; from kris@FreeBSD.org on Wed, Mar 29, 2000 at 11:27:48AM -0800 X-Operating-System: FreeBSD 5.0-CURRENT i386 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Wed, Mar 29, 2000 at 11:27:48AM -0800, Kris Kennaway wrote: > No, it's a definite problem. If you have CFLAGS set in make.conf (this is > a prerequisite for demonstrating the problem), you cannot override it from > within a port, e.g. if you need to add a -DFOO setting to get it to > compile. > > I had to hack around this in USE_OPENSSL by adding an OPENSSL_CFLAGS which > needy ports would be taught to use. See pipsecd and bonnie for two ports > which want to play with CFLAGS. It works on my system, with CFLAGS= -O -pipe and in games/kbubbles/Makefile, CFLAGS+=-v ..reg pointed out this problem is limited to ports without configure scripts.. which I confirmed in my mail/mreport port. Perhaps what we should do is implement something similar to the PCFLAGS hack I've been using in some of my ports. Like, save the environment CFLAGS to a separate variable such as SAVEFLAGS, then set CFLAGS="${PCFLAGS}", which is set in the port Makefile, then set CFLAGS+=${SAVEFLAGS}. Something like that.. did that make sense? -- Will Andrews GCS/E/S @d- s+:+>+:- a--->+++ C++ UB++++ P+ L- E--- W+++ !N !o ?K w--- ?O M+ V-- PS+ PE++ Y+ PGP+>+++ t++ 5 X++ R+ tv+ b++>++++ DI+++ D+ G++>+++ e->++++ h! r-->+++ y? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message