From owner-freebsd-current@freebsd.org Fri Feb 15 19:54:12 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 98C5E14E71F1 for ; Fri, 15 Feb 2019 19:54:12 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 2255282604 for ; Fri, 15 Feb 2019 19:54:12 +0000 (UTC) (envelope-from ian@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id D9DA414E71F0; Fri, 15 Feb 2019 19:54:11 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B4E0A14E71EF for ; Fri, 15 Feb 2019 19:54:11 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3227982602 for ; Fri, 15 Feb 2019 19:54:10 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1550260412; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=RY6GZ1JD9+WnbDNgakR5pBZbtSl8epz95jubmpVzkLLzsZb4wbEJkooFzq84cVQBD+tKEjkvl7HNP LJIgx1YICx/WOY89g1y1zo58opwLbxQjG7QDx3nUTGHROsvtNkhnjupJYo00Cd1z4iHCPBj8NRP1t9 ePGYFIAJ8gBWLY65z0j29uXWdI9IFeGaFBrooVh13IAaEeMm9lipkfbKZ9mRAuTaoCdVHoPb2B5O2T zVZghMoO+xCD9a4FYL83Uyd+P+LLhYKUFR2mWrN1fe1YOQqGz5vw3FY7hKVc3x2RH3HFULNABOYP4T YHM1nz5+/ScL0P5n5SP+ucQDUrKK8TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=ROGAbf9dGn3pW/09mAS5NJEb+mJdcCnMz6kulZhr+Ko=; b=SAMeE25NjA/DWyEoEBf5oUtcdRWqYbfmrUDkbji3CLaprdrw1SWxzLwL65x3jmVieCDjEqqnRj1RK O9c0vHCySKH6OWtrczB27/G7JVr0SSutziK7UfA7Ab8Et0yTx6ZoZbp1QTqz/iqF3c0PXJ/u7AUXTg a880JAo8ITtGNzodszTXPSY8S7w2tDMbNtbOJMzynrynHQWOeggqDo1PiFbnuZoYbujxAYqLRdoZtL UUyaswSoP1SzFxjyFLvtNRBJN6q6DnBjkdGeNraw+d/gg7mJ24UIevp7JUxsGjPO5xAUE+feEf7/ar uPjUrvVQrsVyiwhYCbLnXgXabnEf52w== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=ROGAbf9dGn3pW/09mAS5NJEb+mJdcCnMz6kulZhr+Ko=; b=WegavDGTgaXET9Q2qQfj5a0zpSAP1vCzZ4dJBlhuowkr62OXt8O/IhFWo0Q7ePS2R8gfLccsWApJr GzfkAPl+Rio2B8WqY5tNQvJXnHWjd+x6Du/BxCSH1kI214PXMhh8nyPuxUTHMZDSOSk6J0Dl8FtCQC POnXBXn/aNyvsRgcXaDOM74LiiMjDNzw9MYfMxEtvQopyZEhUlvuYCrfpSVDk9w6c89V6qgmQITovS rWvuUWeRwC4STzP5xsPuTjaXpioVueuO5fWI6XHfZ/8fSXvAeFFZK47T5PE4307bFihv8kEKkAjwmT cXZ6PEBXKHskNzSNELXssFhBXWRuWKw== X-MHO-RoutePath: aGlwcGll X-MHO-User: 5d914c87-315b-11e9-9789-75353a1f43cf X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id 5d914c87-315b-11e9-9789-75353a1f43cf; Fri, 15 Feb 2019 19:53:30 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x1FJs1XE070010; Fri, 15 Feb 2019 12:54:01 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <50b76fd19c51acda91ca56d429b5539053ce74a9.camel@freebsd.org> Subject: Re: problem building dev/e1000 From: Ian Lepore To: Warner Losh Cc: Enji Cooper , Eric Joyner , Robert Huff , FreeBSD Current Date: Fri, 15 Feb 2019 12:54:01 -0700 In-Reply-To: References: <23653.56460.521599.489556@jerusalem.litteratus.org> <754B5C21-656B-4A67-BA39-50BB4AF5C0CD@gmail.com> <652F1541-52DE-4744-8AEA-8EE6434E04E8@gmail.com> <39629f6cb41cff32b348cf5d329d425352c28464.camel@freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3227982602 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.993,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Feb 2019 19:54:12 -0000 On Fri, 2019-02-15 at 12:32 -0700, Warner Losh wrote: > On Fri, Feb 15, 2019 at 12:17 PM Ian Lepore wrote: > > > On Fri, 2019-02-15 at 10:53 -0800, Enji Cooper wrote: > > > > [...] > > > > > > HO Eric! > > > > > > iflib was a recently added requirement on stable/12 IIRC..? > > > > > > Does the manpage note this dependency, and is there an UPDATING > > > entry > > > for this change? > > > > > > Thanks! > > > -Enji > > > > > > > My question would be: why? If some drivers have a new dependency on > > iflib, why isn't that expressed in sys/conf/files and handled > > automatically? > > > > Right now we have > > files:net/iflib.c optional ether pci iflib > > in the files file. This would need to change to > > files:net/iflib.c optional ether pci (em | igb | ...) > > but we don't have a () operator in config. Or we'd need dozens of > lines, > and the duplicate elimination code in config has been tricky (though > I > didn't check it just now). > > Warner > I guess the question would be how many things does '...' represent now and in the future? What it would need to be, given our current inflexible config(8) is net/iflib.c optional ether pci em | ether pci igb | ... So if ... is 2 or 3 more drivers, that's not so bad. If iflib is eventually going to be used by dozens of drivers, even the parens would make for a pretty ugly solution. -- Ian