From owner-freebsd-net@FreeBSD.ORG Wed Apr 15 12:29:34 2015 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7F752ADA for ; Wed, 15 Apr 2015 12:29:34 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 088A566E for ; Wed, 15 Apr 2015 12:29:32 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t3FCQS2d029102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 15 Apr 2015 15:26:28 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t3FCQRDW029101; Wed, 15 Apr 2015 15:26:27 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 15 Apr 2015 15:26:27 +0300 From: Gleb Smirnoff To: Luigi Rizzo Cc: net@freebsd.org Subject: Re: moving ALTQ out of contrib Message-ID: <20150415122627.GZ883@glebius.int.ru> References: <20150414135346.GU883@FreeBSD.org> <20150415073823.GA94402@onelab2.iet.unipi.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150415073823.GA94402@onelab2.iet.unipi.it> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2015 12:29:34 -0000 On Wed, Apr 15, 2015 at 09:38:23AM +0200, Luigi Rizzo wrote: L> > With the new ifnet KPI, that is now being developed in projects/ifnet, L> > the ALTQ will need some tweaking. It is discontinued by initial author L> > for a decade now, and it has already experienced direct commits in L> > our tree. Thus, I see no good reasons to continue keeping it in contrib. L> > In NetBSD they have it in sys/altq. L> > L> > I'd prefer to move it to sys/net/altq. L> > L> > Any objections or better ideas? L> L> my first question is what is the expected residual lifetime of altq ? If I get it working properly in projects/ifnet, I see no reasons to remove it. It is going to be a plugin into network stack and will no longer require editing drivers. It will run on drivers that aren't supported by ALTQ now. However in the latter case the ALTQ will sit on top of interface own queue, and will start to work only when interface's own queue overflows. But if we later add a new interface method to modify length of own queue at runtime, this issue will go away. L> If it is destined to be removed soon (and probably that is not L> unlikely given its unmaintained state, the absence of multiqueue L> support etc.) maybe we could live for the next L> couple of years just leaving it where it is now and avoid the L> repo churn. L> L> If we really plan to relocate the code, I guess the options are L> L> sys/altq as in netbsd L> L> sys/netaltq this would be an alternative location to L> the above one, justified by the fact that L> we have already a bunch of net* subdirs L> L> sys/net/altq as you propose, i guess to stay close to L> the rest of the ifnet code (and perhaps L> as a first step in cleaning up sys/net L> by putting stuff in various subdirs) L> L> In any case my preference would really be to leave it where it is. I don't like to keep in contrib a code maintained and edited by the project. Especially I don't like tautological path of contrib/altq/altq. I don't like extra glue in Makefiles, especially modyfing CFLAGS for the whole kernel build. If it is a regular piece of kernel code, let it be like the rest of kernel code. -- Totus tuus, Glebius.