From owner-freebsd-bugs@freebsd.org Mon May 13 07:55:03 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 063E91584040 for ; Mon, 13 May 2019 07:55:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 951D06D777 for ; Mon, 13 May 2019 07:55:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 59052158403A; Mon, 13 May 2019 07:55:02 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 350321584039 for ; Mon, 13 May 2019 07:55:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C4E066D773 for ; Mon, 13 May 2019 07:55:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 1E098570B for ; Mon, 13 May 2019 07:55:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x4D7t0k5001470 for ; Mon, 13 May 2019 07:55:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x4D7t0WV001469 for bugs@FreeBSD.org; Mon, 13 May 2019 07:55:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 237869] is_random_seeded should perform pre_read for unseeded case Date: Mon, 13 May 2019 07:55:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: delphij@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 May 2019 07:55:03 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D237869 Bug ID: 237869 Summary: is_random_seeded should perform pre_read for unseeded case Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: delphij@FreeBSD.org I noticed the following on a recent -CURRENT amd64 system, this message on boot: arc4random: WARNING: initial seeding bypassed the cryptographic random devi= ce because it was not yet seeded and the knob 'bypass_before_seeding' was enab= led. Despite /boot/entropy is preloaded. It looks like it was related to r34635= 8. On my system, the call path is roughly: vnet_domain_init_inet_vnet_init -> arc4random() At the time, the entropy device have already seen /boot/entropy through random_harvestq_prime(), however, because nobody have read from entropy dev= ice, the pre_read method was never called, therefore the device would report its= elf as unseeded, even though it already have enough entropy to proceed. (By the way, r346292 should be reverted now that r346358 is landed). It looks like is_random_seeded should do something like: if (__predict_false(!p_random_alg_context->ra_seeded())) { p_random_alg_context->ra_pre_read(); return (p_random_alg_context->ra_seeded()); } return (true); Instead of its current form. Note that random_infra.c needs similar treatment as well; the current form = is broken by the way. --=20 You are receiving this mail because: You are the assignee for the bug.=