From owner-freebsd-emulation@FreeBSD.ORG Mon Mar 3 17:27:16 2008 Return-Path: Delivered-To: emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 05C001065672 for ; Mon, 3 Mar 2008 17:27:16 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247]) by mx1.freebsd.org (Postfix) with ESMTP id C05138FC21 for ; Mon, 3 Mar 2008 17:27:15 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id F41B4675E94; Mon, 3 Mar 2008 18:27:13 +0100 (CET) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6DwbFt3roDBU; Mon, 3 Mar 2008 18:27:00 +0100 (CET) Received: from vlk.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 30195675E90; Mon, 3 Mar 2008 18:27:00 +0100 (CET) Received: (from rdivacky@localhost) by vlk.vlakno.cz (8.13.8/8.13.8/Submit) id m23HQxea066081; Mon, 3 Mar 2008 18:26:59 +0100 (CET) (envelope-from rdivacky) Date: Mon, 3 Mar 2008 18:26:59 +0100 From: Roman Divacky To: Alexander Leidinger Message-ID: <20080303172659.GA65716@freebsd.org> References: <20080217162938.GA82845@freebsd.org> <20080303115420.6fm3xuto6c8kcssk@webmail.leidinger.net> <20080303150607.GB47887@freebsd.org> <20080303174101.e6xfqplzuo404wkw@webmail.leidinger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080303174101.e6xfqplzuo404wkw@webmail.leidinger.net> User-Agent: Mutt/1.4.2.3i Cc: emulation@freebsd.org Subject: Re: epoll patch for review X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Mar 2008 17:27:16 -0000 > >I am not sure if its semantically correct, it seems to work for my testing > >program. I'll remove the comment. > > I'm not sure your testing program covers all cases. So just removing > the comment to make me happy is not the right thing to do. :) I tested this flag and it did the same thing on linux and on linuxulator :) > > What I meant was: linux supports the MOD so we should support it too. > You already thought about it (ADD+DEL), so think a little bit more and > finish it (it doesn't look like it is a lot of code to write for > this). And as a second thought: the action to do may depend upon the > modification requested (when it is in fact a null op, we should maybe > do just nothing)... things can always be added later. I'd prefer to commit solution for 95% of the problems now instead of solution for 100% in 2012 > Oh... with fc4 or f7? What's the lib? Maybe we (bsam and/or me) can a > find it and add it as a port. check ltp-full-20061121/testcases/kernel/syscalls/epoll/README.1ST it needs some couroutine library etc. > >thnx for the review I'll fix things and post updated version in a few days > > Many thanks for working at this! sure.... happy to be useful ;) roman