From owner-freebsd-bugs Sun Jun 24 23:20: 5 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 4B8CB37B405 for ; Sun, 24 Jun 2001 23:20:03 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.3/8.11.3) id f5P6K3B90675; Sun, 24 Jun 2001 23:20:03 -0700 (PDT) (envelope-from gnats) Date: Sun, 24 Jun 2001 23:20:03 -0700 (PDT) Message-Id: <200106250620.f5P6K3B90675@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Phil Homewood Subject: Re: kern/28164: [PATCH] crashdump can trash disklabel/other partitions Reply-To: Phil Homewood Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR kern/28164; it has been noted by GNATS. From: Phil Homewood To: Bruce Evans Cc: FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: kern/28164: [PATCH] crashdump can trash disklabel/other partitions Date: Mon, 25 Jun 2001 16:15:46 +1000 Bruce Evans wrote: > I think you are just trashing the label becauses it is inside da1s2b, not > overrunning da1s2b. That was a conclusion I was starting to draw, too. > This is certainly a bug. The label is write protected > in software, but the dump routines don't even know that the label is there. Should it be there? > This bug is not seen in most configurations because the dump partition > usually starts at a nonzero offset. Yep. Is this configuration acceptable ('b' is a swap partition) or should it start at non-zero offset? Alas, I can't remember if it was /stand/sysinstall or /dev/luser who put it there like that. > Untested incomplete fixes (the boot block area should also be protected...): Will test 'em tomorrow and let you know. Thanks. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message