From owner-freebsd-bugs@FreeBSD.ORG  Tue Jan 25 21:46:09 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E988116A4CE
	for <freebsd-bugs@freebsd.org>; Tue, 25 Jan 2005 21:46:09 +0000 (GMT)
Received: from ppsw-5.csi.cam.ac.uk (ppsw-5.csi.cam.ac.uk [131.111.8.135])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A401843D41
	for <freebsd-bugs@freebsd.org>; Tue, 25 Jan 2005 21:46:09 +0000 (GMT)
	(envelope-from sos22@cantab.net)
Received: from hermes-1.csi.cam.ac.uk ([131.111.8.51]:57929
	helo=archibold.nowhere)
	by ppsw-5.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.155]:25)
	with smtp id 1CtYVi-0004iL-Il (Exim 4.44)
	(return-path <sos22@cantab.net>); Tue, 25 Jan 2005 21:46:06 +0000
Received: by archibold.nowhere (sSMTP sendmail emulation);
	Tue, 25 Jan 2005 21:46:06 +0000
Date: Tue, 25 Jan 2005 21:46:06 +0000
From: Steven Smith <sos22@cantab.net>
To: freebsd-bugs@freebsd.org
Message-ID: <20050125214606.GB1113@archibold>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="IrhDeMKUP4DT/M7F"
Content-Disposition: inline
X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/
X-Cam-AntiVirus: No virus found
X-Cam-SpamDetails: Not scanned
cc: sos22@srcf.ucam.org
Subject: Dubious #define in include/pwd.h
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Jan 2005 21:46:10 -0000


--IrhDeMKUP4DT/M7F
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

I was messing around with sparse, the static checker used sometimes
by Linux kernel people, and I (or rather, it) came upon the line

#define _PW_VERSION_MASK        '0xF0'

in /usr/src/include/pwd.h.  I can't immediately see any use for this;
'\xf0' would probably be more useful.

Of course, it doesn't appear that anyone's actually using the define,
so it doesn't make any actual difference.

Steven Smith.

--IrhDeMKUP4DT/M7F
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)

iD8DBQFB9r4eO4S8/gLNrjcRAoLLAKCiowDw2Bta2KFQ1+jMgzbcOonwOACfZaTa
3rAvk6+zjHYqIf8KeK9tXn0=
=0K5+
-----END PGP SIGNATURE-----

--IrhDeMKUP4DT/M7F--