From owner-p4-releng  Sat Apr  6 15:32:41 2002
Delivered-To: p4-releng@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 15F3837B405; Sat,  6 Apr 2002 15:32:34 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mao.stokely.org (mao.stokely.org [65.84.64.228])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1055237B404; Sat,  6 Apr 2002 15:32:33 -0800 (PST)
Received: by mao.stokely.org (Postfix, from userid 2074)
	id DD9EA4B669; Sat,  6 Apr 2002 15:32:32 -0800 (PST)
Date: Sat, 6 Apr 2002 15:32:32 -0800
From: Murray Stokely <murray@FreeBSD.org>
To: "Bruce A. Mah" <bmah@FreeBSD.org>
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 8929 for review
Message-ID: <20020406233232.GR5732@freebsdmall.com>
References: <200204022153.g32LrnQ29689@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200204022153.g32LrnQ29689@freefall.freebsd.org>
User-Agent: Mutt/1.3.25i
X-GPG-Key-ID: 1024D/0E451F7D
X-GPG-Key-Fingerprint: E2CA 411D DD44 53FD BB4B  3CB5 B4D7 10A2 0E45 1F7D
Sender: owner-p4-releng@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-releng.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-releng>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-releng>
X-Loop: FreeBSD.ORG

  I think this should be made in CVS, possibly with 1 line comment
summarizing the rationale.

	    - Murray

On Tue, Apr 02, 2002 at 01:53:49PM -0800, Bruce A. Mah wrote:
> http://people.freebsd.org/~peter/p4db/chv.cgi?CH=8929
> 
> Change 8929 by bmah@bmah_intruder on 2002/04/02 13:52:50
> 
> 	Don't make the assumption that source files are writable.
> 	The FDP infrastructure has a few constructs of the form
> 	"cp foo bar; cat baz >> bar".  This breaks if foo isn't
> 	writable (as is frequently the case in P4 work directory).
> 	
> 	I'm not sure if this change should be made in CVS or not,
> 	and if so, if this is exactly the right change.  In the meantime,
> 	we've at least unbroken doc builds out of P4 work areas.
> 
> Affected files ...
> 
> ... //depot/releng/5_dp1/doc/share/mk/doc.docbook.mk#2 edit
> 
> Differences ...
> 
> ==== //depot/releng/5_dp1/doc/share/mk/doc.docbook.mk#2 (text+ko) ====
> 
> @@ -413,7 +413,8 @@
>  	${LN} -f ${.ALLSRC} ${.TARGET}
>  
>  ${DOC}.tex-pdf: ${SRCS} ${IMAGES_PDF} ${INDEX_SGML} ${PRINT_INDEX}
> -	${CP} -p ${PDFTEX_DEF} ${.TARGET}
> +	${RM} -f ${.TARGET}
> +	${CAT} ${PDFTEX_DEF} > ${.TARGET}
>  	${JADE} -V tex-backend ${PRINTOPTS} -ioutput.print.pdf \
>  		${JADEOPTS} -t tex -o /dev/stdout ${MASTERDOC} >> ${.TARGET}
>  
> @@ -726,7 +727,8 @@
>  
>  .if ${LOCAL_CSS_SHEET} != ${CSS_SHEET}
>  ${LOCAL_CSS_SHEET}: ${CSS_SHEET}
> -	${CP} -p ${.ALLSRC} ${.TARGET}
> +	${RM} -f ${.TARGET}
> +	${CAT} ${.ALLSRC} > ${.TARGET}
>  .if defined(CSS_SHEET_ADDITIONS)
>  	${CAT} ${.CURDIR}/${CSS_SHEET_ADDITIONS} >> ${.TARGET}
>  .endif

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-releng" in the body of the message