From owner-svn-src-all@FreeBSD.ORG  Mon Jan  6 06:53:23 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 79D91B72;
 Mon,  6 Jan 2014 06:53:23 +0000 (UTC)
Received: from mail-pa0-x230.google.com (mail-pa0-x230.google.com
 [IPv6:2607:f8b0:400e:c03::230])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3D6421C8F;
 Mon,  6 Jan 2014 06:53:23 +0000 (UTC)
Received: by mail-pa0-f48.google.com with SMTP id rd3so18168566pab.7
 for <multiple recipients>; Sun, 05 Jan 2014 22:53:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=from:date:to:cc:subject:message-id:reply-to:references:mime-version
 :content-type:content-disposition:in-reply-to:user-agent;
 bh=ln3veuJ3GXTc5KP76+a5uijOW3WLEaBqkWHRMn1GblI=;
 b=Lv7twtdOHcIH6DjjNOH3cYt/0AOIbn81XQWKu77JSnY9gC0HfYRvJXcEvc2p8Fycc1
 kb3Fb24JnX0OLpzJ7gdx8wunsDrZyymQKSBFegAesRNBKzsQS1Gdwb99Xt9V/o1pSCWQ
 1pxhc0VoehuNCyoIw5QMWn4jxZzs2KdmKec6XohKSkNrS/3Vx06FrCahqGE3Zk7k4H3T
 PTeLMs/ItU6rSHeB9ZJjYOteo9DIbYnIQheyWZ+6a9Tv0nRUaRZlLYvDxu6Y5SbMo1i7
 RNNPCzuGGIjCp89G2tymhWNFZK54UhSdmhXxXQnBlR0juUt0rerA4++pQC3JaB5z8v3u
 GwKg==
X-Received: by 10.68.130.10 with SMTP id oa10mr3376008pbb.160.1388991201728;
 Sun, 05 Jan 2014 22:53:21 -0800 (PST)
Received: from pyunyh@gmail.com (lpe4.p59-icn.cdngp.net. [114.111.62.249])
 by mx.google.com with ESMTPSA id ko10sm114094665pbd.38.2014.01.05.22.53.17
 for <multiple recipients>
 (version=TLSv1 cipher=RC4-SHA bits=128/128);
 Sun, 05 Jan 2014 22:53:20 -0800 (PST)
Received: by pyunyh@gmail.com (sSMTP sendmail emulation);
 Mon, 06 Jan 2014 15:53:14 +0900
From: Yonghyeon PYUN <pyunyh@gmail.com>
Date: Mon, 6 Jan 2014 15:53:14 +0900
To: Gleb Smirnoff <glebius@FreeBSD.org>
Subject: Re: svn commit: r260224 - head/sys/netinet
Message-ID: <20140106065314.GB1372@michelle.cdnetworks.com>
References: <201401031103.s03B3CAf013123@svn.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201401031103.s03B3CAf013123@svn.freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: pyunyh@gmail.com
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Jan 2014 06:53:23 -0000

On Fri, Jan 03, 2014 at 11:03:12AM +0000, Gleb Smirnoff wrote:
> Author: glebius
> Date: Fri Jan  3 11:03:12 2014
> New Revision: 260224
> URL: http://svnweb.freebsd.org/changeset/base/260224
> 
> Log:
>   Make failure of ifpromisc() a non-fatal error. This makes it possible to
>   run carp(4) on vtnet(4).
>   

vtnet(4) is the only device that doesn't correctly support
promiscuous mode?  I don't know details of vtnet(4) but it seems
it's not hard to mimic promiscuous mode.  I'm not sure why the
driver returns ENOTSUP to user land given that vtnet(4) defaults
to promiscuous mode for backwards compatibility.  It also does
not handle multicast filter configuration when VTNET_FLAG_CTRL_RX
flag is not set.  If vtnet(4) does not support multicast filter,
it shouldn't announce IFF_MULTICAST. I wonder how vtnet(4) can work
with carp(4) given that its multicast handling is ignored.