From owner-freebsd-bugs Wed Sep 5 3:40:16 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 751AF37B409 for ; Wed, 5 Sep 2001 03:40:07 -0700 (PDT) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.4/8.11.4) id f85Ae2Q89854; Wed, 5 Sep 2001 03:40:02 -0700 (PDT) (envelope-from gnats) Date: Wed, 5 Sep 2001 03:40:02 -0700 (PDT) Message-Id: <200109051040.f85Ae2Q89854@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Murray Stokely Subject: Re: conf/28078: /stand/sysinstall skips distro selection after choosing "no" at final prompt Reply-To: Murray Stokely Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR conf/28078; it has been noted by GNATS. From: Murray Stokely To: freebsd-gnats-submit@FreeBSD.org, cynic@mail.cz Cc: Subject: Re: conf/28078: /stand/sysinstall skips distro selection after choosing "no" at final prompt Date: Wed, 5 Sep 2001 03:38:03 -0700 Hmm, this patch is a quick fix, but I'm not certain that this does the correct thing. For which cases would you expect sysinstall to remember your dists and when do you want to start over with a clean plate? It could be considered a feature that sysinstall remembers your dists for you when you cancel an install in progress. Thoughts? - Murray Index: install.c =================================================================== RCS file: /home/ncvs/src/usr.sbin/sysinstall/install.c,v retrieving revision 1.305 diff -u -r1.305 install.c --- install.c 2001/09/05 00:45:13 1.305 +++ install.c 2001/09/05 10:24:07 @@ -539,6 +539,14 @@ if (DITEM_STATUS(diskLabelEditor(self)) == DITEM_FAILURE) return DITEM_FAILURE; + /* During a standard interactive installation, we want to be + prompted to make a selection of distfiles. Without this, if we + go partially through an install, and then abort, we can't + reselect our distributions again. */ + + if (!variable_get(VAR_NONINTERACTIVE)) + distReset(NULL); + if (DITEM_STATUS((i = installCommit(self))) == DITEM_FAILURE) { dialog_clear(); msgConfirm("Installation completed with some errors. You may wish to\n" To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message