From owner-freebsd-arch@FreeBSD.ORG Tue Jun 6 02:14:59 2006 Return-Path: X-Original-To: freebsd-arch@FreeBSD.org Delivered-To: freebsd-arch@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 26A0F16C2C8 for ; Tue, 6 Jun 2006 01:35:50 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [210.51.165.229]) by mx1.FreeBSD.org (Postfix) with ESMTP id 694FA43D55 for ; Tue, 6 Jun 2006 01:35:47 +0000 (GMT) (envelope-from delphij@delphij.net) Received: from localhost (tarsier.geekcn.org [210.51.165.229]) by tarsier.geekcn.org (Postfix) with ESMTP id 40FADEB1127 for ; Tue, 6 Jun 2006 09:35:39 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([210.51.165.229]) by localhost (mail.geekcn.org [210.51.165.229]) (amavisd-new, port 10024) with ESMTP id g3ulKCHyCkVS for ; Tue, 6 Jun 2006 09:35:34 +0800 (CST) Received: from [10.217.12.139] (sina152-194.staff.sina.com.cn [61.135.152.194]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTP id 64141EB099E for ; Tue, 6 Jun 2006 09:35:33 +0800 (CST) From: Xin LI To: freebsd-arch@FreeBSD.org Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-s+J6VnxokQcJXvZQ2Au8" Organization: The FreeBSD Project Date: Tue, 06 Jun 2006 09:35:29 +0800 Message-Id: <1149557729.6740.3.camel@spirit> Mime-Version: 1.0 X-Mailer: Evolution 2.6.2 FreeBSD GNOME Team Port Cc: Subject: getbsize(3): Convert blocksizep to be unsigned long? X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jun 2006 02:15:00 -0000 --=-s+J6VnxokQcJXvZQ2Au8 Content-Type: multipart/mixed; boundary="=-6zYcs2losBkvLFhSt+Ku" --=-6zYcs2losBkvLFhSt+Ku Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Dear folks, When I was twiddling df(1)'s code I found that getbsize(3) accepts blocksizep as long *. Because that the manual page says: "The memory referenced by blocksizep is filled in with block size, in bytes." I think it makes no sense for the number to be negative. Is it reasonable to apply the attached patch? Cheers, --=20 Xin LI http://www.delphij.net/ --=-6zYcs2losBkvLFhSt+Ku Content-Disposition: attachment; filename=patch-getbsize Content-Type: text/x-patch; name=patch-getbsize; charset=ISO-8859-1 Content-Transfer-Encoding: base64 SW5kZXg6IGluY2x1ZGUvc3RkbGliLmgNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvaG9tZS9uY3Zz L3NyYy9pbmNsdWRlL3N0ZGxpYi5oLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS42Mg0KZGlmZiAt dSAtcjEuNjIgc3RkbGliLmgNCi0tLSBpbmNsdWRlL3N0ZGxpYi5oCTE0IE1hciAyMDA2IDE2OjU3 OjMwIC0wMDAwCTEuNjINCisrKyBpbmNsdWRlL3N0ZGxpYi5oCTYgSnVuIDIwMDYgMDE6Mjc6NTYg LTAwMDANCkBAIC0yMzcsNyArMjM3LDcgQEANCiAJIGFyYzRyYW5kb20odm9pZCk7DQogdm9pZAkg YXJjNHJhbmRvbV9hZGRyYW5kb20odW5zaWduZWQgY2hhciAqZGF0LCBpbnQgZGF0bGVuKTsNCiB2 b2lkCSBhcmM0cmFuZG9tX3N0aXIodm9pZCk7DQotY2hhcgkqZ2V0YnNpemUoaW50ICosIGxvbmcg Kik7DQorY2hhcgkqZ2V0YnNpemUoaW50ICosIHVuc2lnbmVkIGxvbmcgKik7DQogCQkJCQkvKiBn ZXRjYXAoMykgZnVuY3Rpb25zICovDQogY2hhcgkqY2dldGNhcChjaGFyICosIGNvbnN0IGNoYXIg KiwgaW50KTsNCiBpbnQJIGNnZXRjbG9zZSh2b2lkKTsNCkluZGV4OiBsaWIvbGliYy9nZW4vZ2V0 YnNpemUuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9ob21lL25jdnMvc3JjL2xpYi9saWJjL2dl bi9nZXRic2l6ZS5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS43DQpkaWZmIC11IC1yMS43IGdl dGJzaXplLmMNCi0tLSBsaWIvbGliYy9nZW4vZ2V0YnNpemUuYwkzMCBEZWMgMjAwMiAxOTowNDow NiAtMDAwMAkxLjcNCisrKyBsaWIvbGliYy9nZW4vZ2V0YnNpemUuYwk2IEp1biAyMDA2IDAxOjI3 OjU2IC0wMDAwDQpAQCAtMzgsMTcgKzM4LDE2IEBADQogX19GQlNESUQoIiRGcmVlQlNEOiBzcmMv bGliL2xpYmMvZ2VuL2dldGJzaXplLmMsdiAxLjcgMjAwMi8xMi8zMCAxOTowNDowNiBvYnJpZW4g RXhwICQiKTsNCiANCiAjaW5jbHVkZSA8ZXJyLmg+DQorI2luY2x1ZGUgPGVycm5vLmg+DQogI2lu Y2x1ZGUgPHN0ZGlvLmg+DQogI2luY2x1ZGUgPHN0ZGxpYi5oPg0KICNpbmNsdWRlIDxzdHJpbmcu aD4NCiANCiBjaGFyICoNCi1nZXRic2l6ZShoZWFkZXJsZW5wLCBibG9ja3NpemVwKQ0KLQlpbnQg KmhlYWRlcmxlbnA7DQotCWxvbmcgKmJsb2Nrc2l6ZXA7DQorZ2V0YnNpemUoaW50ICpoZWFkZXJs ZW5wLCB1bnNpZ25lZCBsb25nICpibG9ja3NpemVwKQ0KIHsNCiAJc3RhdGljIGNoYXIgaGVhZGVy WzIwXTsNCi0JbG9uZyBuLCBtYXgsIG11bCwgYmxvY2tzaXplOw0KKwl1bnNpZ25lZCBsb25nIG4s IG1heCwgbXVsLCBibG9ja3NpemU7DQogCWNoYXIgKmVwLCAqcDsNCiAJY29uc3QgY2hhciAqZm9y bTsNCiANCkBAIC01OCw4ICs1NywxMSBAQA0KICNkZWZpbmUJTUFYQglHQgkJLyogTm8gdGVyYSwg cGV0YSwgbm9yIGV4YS4gKi8NCiAJZm9ybSA9ICIiOw0KIAlpZiAoKHAgPSBnZXRlbnYoIkJMT0NL U0laRSIpKSAhPSBOVUxMICYmICpwICE9ICdcMCcpIHsNCi0JCWlmICgobiA9IHN0cnRvbChwLCAm ZXAsIDEwKSkgPCAwKQ0KKwkJbiA9IHN0cnRvdWwocCwgJmVwLCAxMCk7DQorCQlpZiAoZXJybm8g PT0gRVJBTkdFKQ0KIAkJCWdvdG8gdW5kZXJmbG93Ow0KKwkJZWxzZSBpZiAoZXJybm8gPT0gRUlO VkFMKQ0KKwkJCW4gPSAwOw0KIAkJaWYgKG4gPT0gMCkNCiAJCQluID0gMTsNCiAJCWlmICgqZXAg JiYgZXBbMV0pDQo= --=-6zYcs2losBkvLFhSt+Ku-- --=-s+J6VnxokQcJXvZQ2Au8 Content-Type: application/pgp-signature; name=signature.asc Content-Description: =?UTF-8?Q?=E8=BF=99=E6=98=AF=E4=BF=A1=E4=BB=B6=E7=9A=84=E6=95=B0?= =?UTF-8?Q?=E5=AD=97=E7=AD=BE=E5=90=8D=E9=83=A8=E5=88=86?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQBEhNvghcUczkLqiksRAmjjAKDNsWakBy90qGqYpsbXO6e9x1yhjQCg3juM 6Bx5NY/iMSdlsy69aCtj7b4= =4SjV -----END PGP SIGNATURE----- --=-s+J6VnxokQcJXvZQ2Au8--