From owner-freebsd-bugs@FreeBSD.ORG Wed Jul 9 13:20:21 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 96BD937B401 for ; Wed, 9 Jul 2003 13:20:21 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id C70D043FDF for ; Wed, 9 Jul 2003 13:20:18 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h69KKIUp042451 for ; Wed, 9 Jul 2003 13:20:18 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h69KKI4v042450; Wed, 9 Jul 2003 13:20:18 -0700 (PDT) Resent-Date: Wed, 9 Jul 2003 13:20:18 -0700 (PDT) Resent-Message-Id: <200307092020.h69KKI4v042450@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Nelson Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1410037B401 for ; Wed, 9 Jul 2003 13:13:02 -0700 (PDT) Received: from dan.emsphone.com (dan.emsphone.com [199.67.51.101]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A47943F85 for ; Wed, 9 Jul 2003 13:13:01 -0700 (PDT) (envelope-from dan@dan.emsphone.com) Received: (from dan@localhost) by dan.emsphone.com (8.12.9/8.12.9) id h69KD0ar094995; Wed, 9 Jul 2003 15:13:00 -0500 (CDT) (envelope-from dan) Message-Id: <200307092013.h69KD0ar094995@dan.emsphone.com> Date: Wed, 9 Jul 2003 15:13:00 -0500 (CDT) From: Dan Nelson To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/54276: pread/pwrite patches for libc db functions X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jul 2003 20:20:21 -0000 >Number: 54276 >Category: bin >Synopsis: pread/pwrite patches for libc db functions >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Jul 09 13:20:18 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Dan Nelson >Release: FreeBSD 5.1-CURRENT i386 >Organization: The Allant Group >Environment: System: FreeBSD dan.emsphone.com 5.1-CURRENT FreeBSD 5.1-CURRENT #276: Fri Jun 27 16:21:53 CDT 2003 dan@dan.emsphone.com:/usr/src/sys/i386/compile/DANSMP i386 >Description: The following patch replaces an lseek+read/write combo with a single pread/pwrite, cutting the number of syscalls by 1/2. All db I/O gets funnelled though mpool_get and mpool_write so these are the only functions that need changing. I've been running with this patch for 3 years and had forgotten about it :) Tested against >100mb btree indexes. >How-To-Repeat: >Fix: Index: mpool.c =================================================================== RCS file: /home/ncvs/src/lib/libc/db/mpool/mpool.c,v retrieving revision 1.10 diff -u -p -r1.10 mpool.c --- mpool.c 22 Mar 2002 21:52:01 -0000 1.10 +++ mpool.c 29 Mar 2002 18:42:00 -0000 @@ -207,9 +207,7 @@ mpool_get(mp, pgno, flags) ++mp->pageread; #endif off = mp->pagesize * pgno; - if (lseek(mp->fd, off, SEEK_SET) != off) - return (NULL); - if ((nr = _read(mp->fd, bp->page, mp->pagesize)) != mp->pagesize) { + if ((nr = pread(mp->fd, bp->page, mp->pagesize, off)) != mp->pagesize) { if (nr >= 0) errno = EFTYPE; return (NULL); @@ -381,9 +379,7 @@ mpool_write(mp, bp) (mp->pgout)(mp->pgcookie, bp->pgno, bp->page); off = mp->pagesize * bp->pgno; - if (lseek(mp->fd, off, SEEK_SET) != off) - return (RET_ERROR); - if (_write(mp->fd, bp->page, mp->pagesize) != mp->pagesize) + if (pwrite(mp->fd, bp->page, mp->pagesize, off) != mp->pagesize) return (RET_ERROR); bp->flags &= ~MPOOL_DIRTY; >Release-Note: >Audit-Trail: >Unformatted: