From owner-freebsd-current Sat May 26 14:59:30 2001 Delivered-To: freebsd-current@freebsd.org Received: from obsecurity.dyndns.org (adsl-63-207-60-60.dsl.lsan03.pacbell.net [63.207.60.60]) by hub.freebsd.org (Postfix) with ESMTP id 9937337B422 for ; Sat, 26 May 2001 14:59:26 -0700 (PDT) (envelope-from kris@obsecurity.org) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 0643666B88; Sat, 26 May 2001 14:59:22 -0700 (PDT) Date: Sat, 26 May 2001 14:59:22 -0700 From: Kris Kennaway To: current@FreeBSD.org Subject: 'make includes' ownership patch Message-ID: <20010526145922.A72087@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="4Ckj6UjgE2iN1+kY" Content-Disposition: inline User-Agent: Mutt/1.2.5i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --4Ckj6UjgE2iN1+kY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Shouldn't the includes/Makefile be installing headers using INCOWN/INCGRP instead of BINOWN/BINGRP? I ran into this when trying to do a 'make includes' as a normal user. Kris Index: include/Makefile =================================================================== RCS file: /home/ncvs/src/include/Makefile,v retrieving revision 1.142 diff -u -r1.142 Makefile --- include/Makefile 2001/05/26 11:57:29 1.142 +++ include/Makefile 2001/05/26 21:57:34 @@ -78,15 +78,15 @@ beforeinstall: ${SHARED} @rm -f ${DESTDIR}/usr/include/timepps.h cd ${.CURDIR}; \ - ${INSTALL} -C -o ${BINOWN} -g ${BINGRP} -m 444 \ + ${INSTALL} -C -o ${INCOWN} -g ${INCGRP} -m 444 \ ${FILES} ${DESTDIR}/usr/include cd ${.CURDIR}/arpa; \ - ${INSTALL} -C -o ${BINOWN} -g ${BINGRP} -m 444 \ + ${INSTALL} -C -o ${INCOWN} -g ${INCGRP} -m 444 \ ${ARPAFILES} ${DESTDIR}/usr/include/arpa cd ${.CURDIR}/protocols; \ - ${INSTALL} -C -o ${BINOWN} -g ${BINGRP} -m 444 \ + ${INSTALL} -C -o ${INCOWN} -g ${INCGRP} -m 444 \ ${PROTOFILES} ${DESTDIR}/usr/include/protocols - ${INSTALL} -C -o ${BINOWN} -g ${BINGRP} -m 444 \ + ${INSTALL} -C -o ${INCOWN} -g ${INCGRP} -m 444 \ ${.OBJDIR}/osreldate.h \ ${DESTDIR}/usr/include .for i in ${LFILES} @@ -109,12 +109,12 @@ -p ${DESTDIR}/usr/include .for i in ${LDIRS} ${LSUBDIRS} cd ${.CURDIR}/../sys; \ - ${INSTALL} -C -o ${BINOWN} -g ${BINGRP} -m 444 $i/*.h \ + ${INSTALL} -C -o ${INCOWN} -g ${INCGRP} -m 444 $i/*.h \ ${DESTDIR}/usr/include/$i .endfor .if exists(${.CURDIR}/../sys/${MACHINE_ARCH}/include) cd ${.CURDIR}/../sys/${MACHINE_ARCH}/include; \ - ${INSTALL} -C -o ${BINOWN} -g ${BINGRP} -m 444 *.h \ + ${INSTALL} -C -o ${INCOWN} -g ${INCGRP} -m 444 *.h \ ${DESTDIR}/usr/include/machine .endif .for i in ${SFILES} --4Ckj6UjgE2iN1+kY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.5 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE7ECc5Wry0BWjoQKURAjtOAJ9EUJsRTmUzcBRZ/fvY5dwdR2R45ACg1M7e kUBCn7of2BIsiIA6uPeBOoE= =0kh1 -----END PGP SIGNATURE----- --4Ckj6UjgE2iN1+kY-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message