From owner-svn-src-all@FreeBSD.ORG Sun Aug 15 13:47:24 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E488B10656A8 for ; Sun, 15 Aug 2010 13:47:23 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 3E9718FC1C for ; Sun, 15 Aug 2010 13:47:23 +0000 (UTC) Received: (qmail 91479 invoked from network); 15 Aug 2010 11:49:47 -0000 Received: from localhost (HELO [127.0.0.1]) ([127.0.0.1]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 15 Aug 2010 11:49:47 -0000 Message-ID: <4C67E9AA.60608@freebsd.org> Date: Sun, 15 Aug 2010 15:20:42 +0200 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.11) Gecko/20100711 Thunderbird/3.0.6 MIME-Version: 1.0 To: "Bjoern A. Zeeb" References: <201008150930.o7F9UD2P054326@svn.freebsd.org> <20100815094057.F48418@maildrop.int.zabbadoz.net> In-Reply-To: <20100815094057.F48418@maildrop.int.zabbadoz.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r211327 - head/sys/netinet X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Aug 2010 13:47:24 -0000 On 15.08.2010 11:41, Bjoern A. Zeeb wrote: > On Sun, 15 Aug 2010, Andre Oppermann wrote: > >> Author: andre >> Date: Sun Aug 15 09:30:13 2010 >> New Revision: 211327 >> URL: http://svn.freebsd.org/changeset/base/211327 >> >> Log: >> Add more logging points for failures in syncache_socket() to >> report when a new socket couldn't be created because one of >> in_pcbinshash(), in6_pcbconnect() or in_pcbconnect() failed. >> >> Logging is conditional on net.inet.tcp.log_debug being enabled. >> >> MFC after: 1 week >> >> Modified: >> head/sys/netinet/tcp_syncache.c >> >> Modified: head/sys/netinet/tcp_syncache.c >> ============================================================================== >> >> --- head/sys/netinet/tcp_syncache.c Sun Aug 15 08:49:07 2010 (r211326) >> +++ head/sys/netinet/tcp_syncache.c Sun Aug 15 09:30:13 2010 (r211327) >> @@ -627,6 +627,7 @@ syncache_socket(struct syncache *sc, str >> struct inpcb *inp = NULL; >> struct socket *so; >> struct tcpcb *tp; >> + int error = 0; > > > Is there any need to initialize here? No. Actually not. Was just my style of using safe initial values. But here the return value is the socket pointer of NULL. The error is not passed back directly. Fixed in r211332. Thanks for noticing and reporting. -- Andre