From owner-freebsd-net@FreeBSD.ORG Mon Feb 2 08:19:54 2009 Return-Path: Delivered-To: freebsd-net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 98C4A106564A; Mon, 2 Feb 2009 08:19:54 +0000 (UTC) (envelope-from krassi@bulinfo.net) Received: from mx.bulinfo.net (mx.bulinfo.net [193.194.156.1]) by mx1.freebsd.org (Postfix) with ESMTP id 476CE8FC20; Mon, 2 Feb 2009 08:19:54 +0000 (UTC) (envelope-from krassi@bulinfo.net) Received: from localhost (localhost [127.0.0.1]) by mx.bulinfo.net (Postfix) with ESMTP id F15F8BF8B; Mon, 2 Feb 2009 09:54:06 +0200 (EET) Received: from mx.bulinfo.net ([127.0.0.1]) by localhost (mx.bulinfo.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 62507-03; Mon, 2 Feb 2009 09:54:06 +0200 (EET) Received: from [192.168.2.188] (pythia.bulinfo.net [212.72.195.5]) by mx.bulinfo.net (Postfix) with ESMTP id 25BEABF4F; Mon, 2 Feb 2009 09:54:06 +0200 (EET) Message-ID: <4986A69B.3030505@bulinfo.net> Date: Mon, 02 Feb 2009 09:54:03 +0200 From: Krassimir Slavchev User-Agent: Thunderbird 2.0.0.14 (X11/20080616) MIME-Version: 1.0 To: vwe@FreeBSD.org References: <200901311033.n0VAXr6R037246@freefall.freebsd.org> In-Reply-To: <200901311033.n0VAXr6R037246@freefall.freebsd.org> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: amavisd-new at mx.bulinfo.net Cc: freebsd-net@FreeBSD.org Subject: Re: bin/118987: ifconfig(8): ifconfig -l (address_family) does not work correctly on RELENG-7 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Feb 2009 08:19:55 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, A few days after filling this PR I received a patch from someone (I will search in my inbox). Here is the patch: - --- /usr/src/sbin/ifconfig/ifconfig.c 2007-12-26 23:25:17.000000000 +0300 +++ /tmp/ifconfig.c 2007-12-26 23:18:53.000000000 +0300 @@ -298,9 +298,12 @@ * Are we just listing the interfaces? */ if (namesonly) { - - if (ifindex > 1) - - printf(" "); - - fputs(name, stdout); + if (afp == NULL || afp->af_af != AF_LINK || + sdl->sdl_type == IFT_ETHER) { + if (ifindex > 1) + printf(" "); + fputs(name, stdout); + } continue; } vwe@FreeBSD.org wrote: > Synopsis: ifconfig(8): ifconfig -l (address_family) does not work correctly on RELENG-7 > > State-Changed-From-To: open->analyzed > State-Changed-By: vwe > State-Changed-When: Sat Jan 31 10:31:59 UTC 2009 > State-Changed-Why: > Will has created a patch for evaluation > > http://www.freebsd.org/cgi/query-pr.cgi?pr=118987 > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFJhqabxJBWvpalMpkRApX6AJ99RNjokukUJoMpPDnDP1oujnQtyQCgknjO 9HrHjtuCvpZ9uVjV/Djw8KU= =nMYy -----END PGP SIGNATURE-----