From owner-freebsd-ports Thu Sep 12 02:50:29 1996 Return-Path: owner-ports Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id CAA25461 for ports-outgoing; Thu, 12 Sep 1996 02:50:29 -0700 (PDT) Received: from nike.efn.org (resnet.uoregon.edu [128.223.170.28]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id CAA25454 for ; Thu, 12 Sep 1996 02:50:25 -0700 (PDT) Received: from localhost (localhost.efn.org [127.0.0.1]) by nike.efn.org (8.7.5/8.7.3) with SMTP id CAA12611; Thu, 12 Sep 1996 02:50:45 -0700 (PDT) Date: Thu, 12 Sep 1996 02:50:43 -0700 (PDT) From: John-Mark Gurney Reply-To: John-Mark Gurney To: "David E. O'Brien" cc: freebsd-ports@freefall.freebsd.org Subject: Re: port of su2 In-Reply-To: <199609120847.BAA03410@relay.nuxi.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-ports@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Thu, 12 Sep 1996, David E. O'Brien wrote: > > this program has not gone through extensive testing... but it seems to > > work fine... someone might want to review the patches... but they seem > > to work fine... hope this helps... ttyl... > > PLEASE read the handbook for how to make a FreeBSD port. I would also > suggest you get almost any existing port and follow its example. Also, > take a glance at /usr/share/mk/bsd.port.mk. It is *very* readable as > makefiles go. sorry.... I've looked through it a couple times... I knew that I was forgetting to read something before I submitted it (i.e. handbook)... and I did read through the bsd.port.mk only thing was that was a few months ago using a old copy... about 3/23/96 snap version :( I have put the corrected copy in ftp://ftp.cdrom.com/pub/FreeBSD/incoming/su2-1.3.port.tar.gz. > 1) Your su2/Makefile does not quite follow the FreeBSD style: > # New ports collection makefile for: figlet > # Version required: 2.1.1 > # Date created: Sat July 20, 1996 > # Whom: David O'Brien (obrien@cs.ucdavis.edu) > # > # $Id$ > # > ... > CATEGORIES+= sysutils I was going to add this last line but I didn't have a ports collection handy :( > 2) su2/work/su2-1.3/Makefile does *NOT* pay attention to $(PREFIX). Change > $(DEST) to $(PREFIX) and this problem will be solved. (the purpose > of ${PREFIX} is to allow people to easly install the program > somewhere else other than /usr/local/). ahh... thanks... I didn't know about that one... > 3) You don't strip the su2 binary (add ``-s'' to the su2 install line in > su2/work/su2-1.3/Makefile). thanks... I decided instead to remove the -g... I was only compiling with -g to find out some wierd bugs that turned up because I didn't chown root and suid it :(... after checking I found out that just removing -g didn't help... so I did add -s on the install line :) > 4) You don't compress the man page. > post-install: > .if !defined{NOMANCOMPRESS} > gzip -9nf ${PREFIX}/man/man1/su2.1 > .endif thanks for this bit of code... I'm quite new to porting stuff to freebsd (I can port code... just not actually make the ports :) )... and I will probably have another port coming down the tubes soon... :) I'll also be submitting a send-pr :) ttyl.. John-Mark gurney_j@efn.org http://resnet.uoregon.edu/~gurney_j/ Modem/FAX: (541) 683-6954 (FreeBSD Box) Live in Peace, destroy Micro$oft, support free software, run FreeBSD (unix)