From owner-freebsd-usb@FreeBSD.ORG Tue Apr 26 10:05:32 2011 Return-Path: Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AA05C106564A for ; Tue, 26 Apr 2011 10:05:32 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe02.c2i.net [212.247.154.34]) by mx1.freebsd.org (Postfix) with ESMTP id 3AD798FC16 for ; Tue, 26 Apr 2011 10:05:31 +0000 (UTC) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.1 cv=oR3+9dOmPeF3nZCt5Gxyvf/bIpfj8bfjGZkkfp/xES8= c=1 sm=1 a=SvYTsOw2Z4kA:10 a=oORb412l5WkA:10 a=WQU8e4WWZSUA:10 a=Q9fys5e9bTEA:10 a=CL8lFSKtTFcA:10 a=i9M/sDlu2rpZ9XS819oYzg==:17 a=DmEDJv4nUOXqZ0pdhmoA:9 a=PUjeQqilurYA:10 a=hg9oRTc3XqTViXGI:21 a=-d6DmIJ3andXDmFt:21 a=i9M/sDlu2rpZ9XS819oYzg==:117 Received: from [188.126.198.129] (account mc467741@c2i.net HELO laptop002.hselasky.homeunix.org) by mailfe02.swip.net (CommuniGate Pro SMTP 5.2.19) with ESMTPA id 118876068; Tue, 26 Apr 2011 12:05:17 +0200 From: Hans Petter Selasky To: Mike Tancsa Date: Tue, 26 Apr 2011 12:04:26 +0200 User-Agent: KMail/1.13.5 (FreeBSD/8.2-STABLE; KDE/4.4.5; amd64; ; ) References: <4DB622D3.2000000@sentex.net> <201104260856.34362.hselasky@c2i.net> In-Reply-To: <201104260856.34362.hselasky@c2i.net> X-Face: *nPdTl_}RuAI6^PVpA02T?$%Xa^>@hE0uyUIoiha$pC:9TVgl.Oq, NwSZ4V"|LR.+tj}g5 %V,x^qOs~mnU3]Gn; cQLv&.N>TrxmSFf+p6(30a/{)KUU!s}w\IhQBj}[g}bj0I3^glmC( :AuzV9:.hESm-x4h240C`9=w MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201104261204.26266.hselasky@c2i.net> Cc: freebsd-usb@freebsd.org Subject: Re: ucom modem issue on recent RELENG_8 X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2011 10:05:32 -0000 On Tuesday 26 April 2011 08:56:34 Hans Petter Selasky wrote: > On Tuesday 26 April 2011 03:41:39 Mike Tancsa wrote: > > Hi, > > > > I have run into a problem where ucom no longer works with a recent > > kernel > > > > from this past week on RELENG_8. I tried the same setup with RELENG_8 > > from Feb 14th and it works as expected. I am about to start narrowing > > it down but was wondering if any one had any hints as to what to try ? > > The symptoms are that large packets fail. > > There has been some EHCI patches in 8-stable recently. Else there hasn't > been many changes at all with regard to USB. Reviewing one of my patches, I think I might have introduced a small bug related to sending of ZLP's. Can you apply this patch and report back? === ehci.c ================================================================== --- ehci.c (revision 220904) +++ ehci.c (local) @@ -1196,6 +1196,8 @@ dt ^= 1; /* short packet at the end */ else if (actlen != xlen) dt ^= 1; /* zero length packet at the end */ + else if (xlen == 0) + dt ^= 1; /* zero length transfer */ xfer->endpoint->toggle_next ^= dt; --HPS