From owner-freebsd-current@freebsd.org Tue Aug 21 14:12:03 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2E63E1073C32 for ; Tue, 21 Aug 2018 14:12:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x234.google.com (mail-it0-x234.google.com [IPv6:2607:f8b0:4001:c0b::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B57C7854C1 for ; Tue, 21 Aug 2018 14:12:02 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x234.google.com with SMTP id d16-v6so11112696itj.0 for ; Tue, 21 Aug 2018 07:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=NTAnc2urt+6hcaxE/lmMU6wS8xkCRaT7gyVrZuhilR0=; b=pJKu22ABwED/8a40AYO0rCv07UEyQXB/m3P4527VZgtliDhIcfpRVKFOFbnHndO9Dj 4AixlAdJi95cpD/vHaNt3m7SJpX70X5dbmNDFQr55hwN8Wt/QdcWA9CvgZs1+KsL+U46 c1tj2/2JRLDztftZIRQJ7X4L/NlerI2fLudQrJvi/KErNPvLDtPbUFvOg8/gJPfopzn9 ahSzdY3ITV55o99NTqTdDrwX6glYtY312c+9YHUi6B2HJAHQb9aa2hHGtkLlkohDYpRJ fOYeTGvqDKBfqvn2U1gYvzJ498VJjWk8r8ymeSrzx/2mvkN/futYZ4kKGWCPQVuT48xz 4R2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=NTAnc2urt+6hcaxE/lmMU6wS8xkCRaT7gyVrZuhilR0=; b=KK+9KuX33dzJMWi0QHX67Id/r4pFEoHSH6Nlq/FyC4oiyA+2t9kJKNP9G/27W0boLR pSIkWVUWyJWgCJBS11zWeMcBnuSJPkNrkNqlASbmeHoDwMQvKjNCd9TudvK66p/lKW8O y7Dq4gbNh6hgQkt+f2e5mIdz+GN+fFxY6tLUzf1PTWK0gn0v+WXXnMwNZPb14kpMkmya CThcNhSyvUj0xaopYqrhSRYDKqgirABk4ghmRJQIiMpuOopcZukT3fFFIEZcrXzcyNZO mReosWcmkJDjBNSuc1BMvpeZCcv2VWM/7kqNIVxSw/tL3ynE77I8vjztj5cIpw693Kep 9ePg== X-Gm-Message-State: AOUpUlGNwXuiq2JwmhXCNnk7a7Ki7EQ39crJW+jLxlVz6gLghO4nHC3a kZwclcrxCCu+C3cH2F7nTpO9HKaq5atas7ECC9lhzg== X-Google-Smtp-Source: AA+uWPwUUWw3dVxpxTLdt0pM1EElPnLrUSoSczENq/yqySenwT8pgyB91T9cNaAxPWUhY/5SxPDb88Zp1/eddqB5hUE= X-Received: by 2002:a24:d2:: with SMTP id 201-v6mr17019835ita.60.1534860721931; Tue, 21 Aug 2018 07:12:01 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:2806:0:0:0:0:0 with HTTP; Tue, 21 Aug 2018 07:12:01 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: <20180820212448.571e1060@thor.intern.walstatt.dynvpn.de> <20180820220103.3ac8a3ac@thor.intern.walstatt.dynvpn.de> <6040ed15-143f-9a6d-8f37-b25a7e2d2036@FreeBSD.org> From: Warner Losh Date: Tue, 21 Aug 2018 08:12:01 -0600 X-Google-Sender-Auth: yLhSXoUW1ApYWZfxsifxN4Sf1Ao Message-ID: Subject: Re: buildworld failure: Do not include ${SRCTOP}/sys when building bootstrap tools To: John Baldwin Cc: "O. Hartmann" , FreeBSD CURRENT , Alex Richardson Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 14:12:03 -0000 On Tue, Aug 21, 2018 at 7:49 AM, Warner Losh wrote: > > > On Tue, Aug 21, 2018 at 12:38 AM, John Baldwin wrote: > >> On 8/20/18 9:00 PM, O. Hartmann wrote: >> > -----BEGIN PGP SIGNED MESSAGE----- >> > Hash: SHA512 >> > >> > Am Mon, 20 Aug 2018 21:24:21 +0200 >> > "O. Hartmann" schrieb: >> > >> >> -----BEGIN PGP SIGNED MESSAGE----- >> >> Hash: SHA512 >> >> >> >> Building NanoBSD world on CURRENT r338113 fails due to: >> >> >> >> [...] >> >> cd /pool/sources/CURRENT/src/rescue/rescue/../../sbin/gbde && >> MK_TESTS=no >> >> UPDATE_DEPENDFILE=no _RECURSING_CRUNCH=1 >> >> MAKEOBJDIRPREFIX=/pool/nanobsd/amd64/ALERICH_amd64/pool/ >> sources/CURRENT/src/amd64.amd64/rescue/rescue >> >> make MK_AUTO_OBJ=no DIRPRFX=rescue/rescue/gbde/ -DRESCUE >> CRUNCH_CFLAGS=-DRESCUE >> >> MK_AUTO_OBJ=no obj make[5]: "/pool/sources/CURRENT/src/too >> ls/build/mk/Makefile.boot" >> >> line 18: Do not include ${SRCTOP}/sys when building bootstrap tools. >> Copy the header to >> >> ${WORLDTMP}/legacy in tools/build/Makefile instead. Error was caused >> by Makefile >> >> in /pool/sources/CURRENT/src/sbin/gbde *** [obj_crunchdir_gbde] Error >> code 1 >> >> >> >> make[4]: stopped in /pool/sources/CURRENT/src/rescue/rescue >> >> [...] >> >> >> >> >> >> This problem occured during today's source updates since I was able to >> build the NanoBSD >> >> image I intend to build yesterday ~ r338060. >> >> >> >> What is going wrong? >> > >> > It seems the problem has been introduced after r338095, since r338095 >> builds ok, while >> > r338096 doesn't. >> >> 338096 added this check to catch a kind of error in our Makefiles. Alex >> (cc'd) can >> help with figuring out what the error is. >> > > Except we're not building anything, we're making obj in rescue... It > looks like a false positive... > weird, I'm dying elsewhere. You can recreate this with cd tools/tools/nanobsd/embedded sh -c ../nanobsd.sh -c qemu-amd64-uefi.cfg it dies in mkimg. We have LOCAL_XTOOL_DIRS=usr.bin/mkimg so it's building in stage 3. It's likely because of CFLAGS+=-I${SRCTOP}/sys/sys/disk which is 100% legit always by design, so the test in this case is a false positive and must be relaxed. I'm guessing that the rescue case above is similar: we're building an different tool early. Warner