From owner-freebsd-current@FreeBSD.ORG  Thu Oct  7 18:25:02 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 675F21065674
	for <freebsd-current@FreeBSD.org>; Thu,  7 Oct 2010 18:25:02 +0000 (UTC)
	(envelope-from jh@FreeBSD.org)
Received: from gw01.mail.saunalahti.fi (gw01.mail.saunalahti.fi
	[195.197.172.115])
	by mx1.freebsd.org (Postfix) with ESMTP id 2430B8FC0C
	for <freebsd-current@FreeBSD.org>; Thu,  7 Oct 2010 18:25:01 +0000 (UTC)
Received: from a91-153-123-205.elisa-laajakaista.fi
	(a91-153-123-205.elisa-laajakaista.fi [91.153.123.205])
	by gw01.mail.saunalahti.fi (Postfix) with SMTP id 96E45151739
	for <freebsd-current@FreeBSD.org>;
	Thu,  7 Oct 2010 21:06:59 +0300 (EEST)
Date: Thu, 7 Oct 2010 21:06:57 +0300
From: Jaakko Heinonen <jh@FreeBSD.org>
To: freebsd-current@FreeBSD.org
Message-ID: <20101007180657.GA1383@a91-153-123-205.elisa-laajakaista.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: 
Subject: HEADS UP: device name checking on device registration
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Oct 2010 18:25:02 -0000


Since r213526 device names are checked on device registration. That is,
if you call a make_dev*() function with an invalid device name, a panic
will occur by default. For make_dev_credf(9) or make_dev_p(9) you can
specify the MAKEDEV_CHECKNAME flag to get an error return instead of a
panic.

Invalid names are as follows:

- empty name
- names longer than SPECNAMELEN
- names containing "." or ".." path component
- names ending with '/'
- already existing device names

So, if you see a "bad si_name" panic you may have encountered a driver
bug.

Currently several GEOM classes (notably geom_label) allow to create
devices with invalid names. Below is a link to a patch which converts
g_dev_taste() to use make_dev_p() with MAKEDEV_CHECKNAME flag. It's not
a complete solution and essentially changes the panic to a printf.

	http://people.freebsd.org/~jh/patches/geom_dev-checkname.diff

-- 
Jaakko