From nobody Mon Apr 27 23:20:12 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g4KL72LLCz6ZrBs for ; Mon, 27 Apr 2026 23:20:31 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g4KL66F4yz3sj7 for ; Mon, 27 Apr 2026 23:20:30 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-35dac556bb2so6247571a91.1 for ; Mon, 27 Apr 2026 16:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777332024; x=1777936824; darn=freebsd.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5to4gJneD4iT+S/FOEtWxIKvXbmESYBRQtQSjv6hQoA=; b=V0XX6GGnFTGOAYMK/RFPIQHe1u0ijLTnzOPvjqutyDWrCQFOvkcFhIC5a2QQ9Ky/Md yi/uvIFaTjEwt0UCoonIMtYYjs6QxxsCoh6q/K6CAGiR1gxh4jeSBNcvwcsmK0q5/v3i SvZvfVCMoc623DGElUBGx5SL8/7VPwfFjahdWS1KyzzdRYf9k0QuuffYmq+SKqDV7AD1 1kLJnuQB7cVwB7hBa1ds7qBTd00go9NN1iA2Yk8Azq4OnNQ3uuuACLpz/Xq3h3nICFBB wranigvirLkrzekK4lz2jo9WXVL/alVObH9KPkvKFvK2Tja5wmHsrmcQaEMFEDzmY2GS 3Uew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777332024; x=1777936824; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5to4gJneD4iT+S/FOEtWxIKvXbmESYBRQtQSjv6hQoA=; b=MATZue8qSabqxjEmjEiiRAkwVSO/yJZlcYmdXQV3uYmvTHtoDTKZJwDYlV6Swf5h2P QrkSFqDeeuvgW2vt7ZCgcdD01Gez8ykieJp7T1uowjMzXaYf6afWbnjv8kiIlwjDrWie vuk90Z8TOYa6ep+ONUWiVtCF/xRGqmY4HugUq/XXADc3Tbe54xfp09ehHM+p+96EWV8K 67bpFqupTnOeBxCbFbPdNWfsIDupD6Eohepeb9X90k2NhX7y7QLiNHD/7gcALjLTOMzv 12SJUpkubzq4PLcMVXfpcTVvqCw5IOnc5O8adsHAuIuElXZBmVrvlgieCf5WUzyLtdoT gQPQ== X-Forwarded-Encrypted: i=1; AFNElJ/yvmS35B+CH10HLAPPbHV7VeOlO9LrTmNZjoDvngECOUoR56yoTHZLN4fSQEP1kjaFg0dtBlcY1KJU769neaRu287UVQ==@freebsd.org X-Gm-Message-State: AOJu0YxK5xCyaxqHFgnF7ECD4B3R4LJhBoEPjxZ0lDaZNuSfaw/nKM2j JwoqV0Fib8QDyKCBi04W4LO8eOiP9YBXuOEvoSB5l/8Rst+90yEtZLt1 X-Gm-Gg: AeBDieunYjrcRIEEVJEdQBni1342qYGKTUmj90Nrugno92OttnuEEL+2rcybVY0KSOF 0bVRnCY/2QJhc5jkQpUN+5gtgUGhcHBNfz5C736Ml8w1erUBTOJB7qWo/Z12/Is+WjHPmM1x9Nu j1FTOJi1JjEDsU1rqARuu+s+4OMype/lb051ctUQOLSCgJaRkx32288ILkuTkTDpcVDiDRJ6CiS KXOtEXcBb/oNlmWGMSaW8XQXyvaBf5vAiMzNqVGNNa7QjPpb/bBa7hX5bfC/h5vClfWpw6jSbHv HsYT0aIjRdShIH9CijXe+sOVfE00zKIsNC+FY4lqIfMey6V5GAU1SXFL80P5zvePJ9NxGZ5MQI+ szY1MSNBPoXQPgmzjel7DHn0nt6sVmtVKVaW40jOpeNW68CW/xMxIY4GYmmCoG+2DIdFj+NzY2A lvETOu4OdnFyvYR0GYrn6G/0PzixsUKuwZQE3gBj8puuOthnofZIgtng1wcr0= X-Received: by 2002:a17:90b:1dc5:b0:364:7467:53e7 with SMTP id 98e67ed59e1d1-36491f89d55mr652093a91.6.1777332024136; Mon, 27 Apr 2026 16:20:24 -0700 (PDT) Received: from smtpclient.apple ([185.153.179.248]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36490dbca93sm663034a91.2.2026.04.27.16.20.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Apr 2026 16:20:23 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: git: 566cc005812b - main - safe_set treat ':' and '#' differently From: "Enji Cooper (yaneurabeya)" In-Reply-To: <24831.1777314998@kaos.jnpr.net> Date: Mon, 27 Apr 2026 16:20:12 -0700 Cc: =?us-ascii?B?PT91dGYtOD9RP0RhZy1FcmxpbmdfU209QzM9QjhyZ3Jhdj89?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <69e8f964.39869.24418b55@gitrepo.freebsd.org> <86jyts1xzr.fsf@ltc.des.dev> <15177.1777314263@kaos.jnpr.net> <86bjf41chq.fsf@ltc.des.dev> <24831.1777314998@kaos.jnpr.net> To: "Simon J. Gerraty" X-Mailer: Apple Mail (2.3864.400.21) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4g4KL66F4yz3sj7 X-Spamd-Bar: ---- > On Apr 27, 2026, at 11:36=E2=80=AFAM, Simon J. Gerraty = wrote: >=20 > Dag-Erling Sm=C3=B8rgrav wrote: >>> The goal here is to ensure a line like that will be ignored. >>=20 >> That's beside the point, which is that your regex is incorrect. It = will >> treat e.g. `:foo` as a comment. >=20 > Which is fine by me. >=20 > That is not a syntax one commonly expects to see in rc.conf.d/* >=20 > safe_eval is used it sitations where we are paranoid, > normally only wanting to read *verified* input, but there are = exceptions > to every rule, and the goal of safe_set is to ensure nothing wicked = gets > eval'd. So I don't mind rejecting :foo=3Dbar Using `:` as a comment marker seems a bit esoteric (at best) =E2=80= =94 especially when it has other meanings in /bin/sh . I'd vote for reverting the change personally, but I=E2=80=99m = not going to be adamant about it. Cheers, -Enji=