From owner-p4-projects Wed Apr 24 18:16:16 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id CDCB437B41A; Wed, 24 Apr 2002 18:16:10 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 4627437B417; Wed, 24 Apr 2002 18:16:09 -0700 (PDT) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.6/8.11.6) with SMTP id g3P1ELw40468; Wed, 24 Apr 2002 21:14:21 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Wed, 24 Apr 2002 21:14:20 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: "Brian F. Feldman" Cc: Perforce Change Reviews Subject: Re: PERFORCE change 10204 for review In-Reply-To: <200204241418.g3OEIIR33520@green.bikeshed.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 24 Apr 2002, Brian F. Feldman wrote: > Robert Watson wrote: > > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=10204 > > > > Change 10204 by rwatson@rwatson_tislabs on 2002/04/23 20:13:49 > > > > Work around existing FreeBSD VFS locking breakage: don't assert > > that vp is locked for mac_cred_check_search_vnode(), because > > apparently it's not. Existing assertions in lookup() already > > catch this same bug, so it's not our fault (and needs to be > > fixed). > > Are you sure ASSERT_VOP_LOCKED() works like you'd expect for shared > locks, too? Not entirely sure, and should check. Interestingly, disabling my assert still results in a panic early in init due to existing adjacent assertions in lookup(). I'm busy unwinding lookup behavior to try and get a grasp of what's going on. I realize VFS locking is a deep pit, but having a few more assertions working would be helpful for debugging this stuff. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message