From owner-freebsd-bugs Mon Jan 27 22:13:19 2003 Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A7F6337B401; Mon, 27 Jan 2003 22:13:17 -0800 (PST) Received: from sccrmhc02.attbi.com (sccrmhc02.attbi.com [204.127.202.62]) by mx1.FreeBSD.org (Postfix) with ESMTP id BE98643F75; Mon, 27 Jan 2003 22:13:16 -0800 (PST) (envelope-from crist.clark@attbi.com) Received: from blossom.cjclark.org (12-234-89-252.client.attbi.com[12.234.89.252]) by sccrmhc02.attbi.com (sccrmhc02) with ESMTP id <2003012806131500200i3mbfe>; Tue, 28 Jan 2003 06:13:15 +0000 Received: from blossom.cjclark.org (localhost. [127.0.0.1]) by blossom.cjclark.org (8.12.6/8.12.3) with ESMTP id h0S6DEeq043281; Mon, 27 Jan 2003 22:13:14 -0800 (PST) (envelope-from crist.clark@attbi.com) Received: (from cjc@localhost) by blossom.cjclark.org (8.12.6/8.12.6/Submit) id h0S6DD0v043280; Mon, 27 Jan 2003 22:13:13 -0800 (PST) X-Authentication-Warning: blossom.cjclark.org: cjc set sender to crist.clark@attbi.com using -f Date: Mon, 27 Jan 2003 22:13:13 -0800 From: "Crist J. Clark" To: Mike Silbersack Cc: freebsd-bugs@FreeBSD.org, Gregory Bond Subject: Re: kern/43348: PATCH: make tcp.log_in_vain distinguish SYN from SYN-ACK Message-ID: <20030128061313.GB42960@blossom.cjclark.org> Reply-To: "Crist J. Clark" References: <200301250056.h0P0uZqq062114@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200301250056.h0P0uZqq062114@freefall.freebsd.org> User-Agent: Mutt/1.4i X-URL: http://people.freebsd.org/~cjc/ Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Fri, Jan 24, 2003 at 04:56:35PM -0800, Mike Silbersack wrote: > Synopsis: PATCH: make tcp.log_in_vain distinguish SYN from SYN-ACK > > Responsible-Changed-From-To: freebsd-bugs->silby > Responsible-Changed-By: silby > Responsible-Changed-When: Fri Jan 24 16:56:20 PST 2003 > Responsible-Changed-Why: > Ok, I'll take a stab at this. Wouldn't it be easier just to add the TCP flags of the offending packet to the log entry like we do for 2? Index: /export/freebsd/CURRENT/src/sys/netinet/tcp_input.c =================================================================== RCS file: /export/freebsd/ncvs/src/sys/netinet/tcp_input.c,v retrieving revision 1.187 diff -u -r1.187 tcp_input.c --- /export/freebsd/CURRENT/src/sys/netinet/tcp_input.c 13 Jan 2003 11:01:19 -0000 1.187 +++ /export/freebsd/CURRENT/src/sys/netinet/tcp_input.c 28 Jan 2003 06:10:59 -0000 @@ -608,9 +608,9 @@ if (thflags & TH_SYN) log(LOG_INFO, "Connection attempt to TCP %s:%d " - "from %s:%d\n", + "from %s:%d flags: 0x%02x\n", dbuf, ntohs(th->th_dport), sbuf, - ntohs(th->th_sport)); + ntohs(th->th_sport), thflags); break; case 2: log(LOG_INFO, -- Crist J. Clark | cjclark@alum.mit.edu | cjclark@jhu.edu http://people.freebsd.org/~cjc/ | cjc@freebsd.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message