From owner-freebsd-bugs@FreeBSD.ORG  Tue Nov 16 14:24:15 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 93BA016A4CE
	for <freebsd-bugs@freebsd.org>; Tue, 16 Nov 2004 14:24:15 +0000 (GMT)
Received: from aiolos.otenet.gr (aiolos.otenet.gr [195.170.0.23])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B8A9A43D4C
	for <freebsd-bugs@freebsd.org>; Tue, 16 Nov 2004 14:24:14 +0000 (GMT)
	(envelope-from keramida@freebsd.org)
Received: from orion.daedalusnetworks.priv (aris.bedc.ondsl.gr
	[62.103.39.226])iAGEOBFb016359;	Tue, 16 Nov 2004 16:24:12 +0200
Received: from orion.daedalusnetworks.priv (orion [127.0.0.1])
	iAGEOAoQ048049;	Tue, 16 Nov 2004 16:24:10 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Received: (from keramida@localhost)iAGEOAQX048048;
	Tue, 16 Nov 2004 16:24:10 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Date: Tue, 16 Nov 2004 16:24:10 +0200
From: Giorgos Keramidas <keramida@freebsd.org>
To: Dmitry Morozovsky <marck@rinet.ru>
Message-ID: <20041116142410.GA48028@orion.daedalusnetworks.priv>
References: <200411161200.iAGC0mir091454@freefall.freebsd.org>
	<20041116165859.C57439@woozle.rinet.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041116165859.C57439@woozle.rinet.ru>
cc: freebsd-bugs@freebsd.org
Subject: Re: misc/73992: periodic security not showing faily firewall diffs
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Nov 2004 14:24:15 -0000

On 2004-11-16 17:00, Dmitry Morozovsky <marck@rinet.ru> wrote:
>On Tue, 16 Nov 2004, Giorgos Keramidas wrote:
>> Wouldn't a better fix be to change the default filter in check_diff()
>> to make sure the correct pattern is used?  I'm thinking of something
>> like this:
>>
>> : Index: security.functions
>> : ===================================================================
>> : RCS file: /home/ncvs/src/etc/periodic/security/security.functions,v
>> : retrieving revision 1.4
>> : diff -u -u -r1.4 security.functions
>> : --- security.functions   23 Sep 2004 02:00:51 -0000      1.4
>> : +++ security.functions   16 Nov 2004 11:55:03 -0000
>> : @@ -44,6 +44,9 @@
>> :    if [ "$1" = "new_only" ]; then
>> :      shift
>> :      filter="grep '^>'"
>> : +    case $daily_status_security_diff_flags in
>> : +      *-u*|*-c*) filter="grep '^+[^+]'" ;;
>> : +    esac
>> :    else
>> :      filter="cat"
>> :    fi
>
> It will miss changes in context diffs (they are marked by '!'), won't it?

Hmmm, true.  I have to think of this a bit more.